Show TQQQ delever allocation in notifications#93
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 19944dcd95
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| allocation_detail = _format_tqqq_volatility_delever_allocation_detail( | ||
| execution, | ||
| prefix=prefix, | ||
| redirect_symbol=redirect_symbol or "QQQ", | ||
| translator=translator, | ||
| ) |
There was a problem hiding this comment.
Omit allocation detail when ratios are unavailable
When dual_drive_volatility_delever_applied is true but the execution payload lacks the new *_retained_ratio/*_redirected_ratio fields and the older *_retention_ratio fallback, this unconditional call still appends an allocation detail rendered as TQQQ retained n/a, QQQM n/a. That payload shape is still supported elsewhere in this repo (for example the TQQQ mapper/snapshot tests only carry the pre-existing delever fields), so older reports or any strategy path that does not populate the new ratios now produce a misleading notification instead of the previous clean risk-control line; consider only adding allocation_detail once at least one ratio can be derived.
Useful? React with 👍 / 👎.
Summary
Validation