[codex] Clarify runtime route roles#98
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 759c8b01d2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @app.get("/probe") | ||
| def probe(): | ||
| return health() | ||
| return session_check() |
There was a problem hiding this comment.
Keep /probe independent of gated session checks
In deployments or schedulers that still use GET/POST /probe as the lightweight probe, this now forwards to session_check(), so the request returns 403 unless FIRSTRADE_RUN_SESSION_CHECK_ON_HTTP=true and can return 500 if that gate is enabled without broker credentials. The existing /probe contract was an always-available service-health response, and .env.example still defaults the session-check gate to false, so this can make health/scheduler probes report the service as failed even when the app is up; use /session-check for the gated broker check or keep /probe on static health semantics.
Useful? React with 👍 / 👎.
Summary
Validation