Skip to content

[codex] Clarify runtime route roles#98

Merged
Pigbibi merged 1 commit into
mainfrom
codex/runtime-route-roles-20260618
Jun 18, 2026
Merged

[codex] Clarify runtime route roles#98
Pigbibi merged 1 commit into
mainfrom
codex/runtime-route-roles-20260618

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add explicit /dry-run alias for strategy dry-run
  • keep existing /precheck compatibility route
  • make /probe call the read-only session/account check instead of static service health
  • update route tests

Validation

  • /home/ubuntu/Projects/platform-runtime-work/.venv/bin/python -m pytest tests/test_request_handling.py

@Pigbibi Pigbibi merged commit 10e917a into main Jun 18, 2026
1 check passed
@Pigbibi Pigbibi deleted the codex/runtime-route-roles-20260618 branch June 18, 2026 13:04

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 759c8b01d2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread main.py
@app.get("/probe")
def probe():
return health()
return session_check()

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep /probe independent of gated session checks

In deployments or schedulers that still use GET/POST /probe as the lightweight probe, this now forwards to session_check(), so the request returns 403 unless FIRSTRADE_RUN_SESSION_CHECK_ON_HTTP=true and can return 500 if that gate is enabled without broker credentials. The existing /probe contract was an always-available service-health response, and .env.example still defaults the session-check gate to false, so this can make health/scheduler probes report the service as failed even when the app is up; use /session-check for the gated broker check or keep /probe on static health semantics.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant