Skip to content

Fix small IBKR Gateway dialog dismissal#71

Merged
Pigbibi merged 1 commit into
mainfrom
fix/dismiss-small-ibkr-dialog
Jun 8, 2026
Merged

Fix small IBKR Gateway dialog dismissal#71
Pigbibi merged 1 commit into
mainfrom
fix/dismiss-small-ibkr-dialog

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • dismiss small IBKR Gateway OK dialogs through the 2FA watcher
  • keep main Gateway windows protected by width/height limits
  • add lightweight checks for the new dismissal guard

Testing

  • for test_file in tests/*.sh; do bash ""; done

@Pigbibi Pigbibi merged commit fa481f0 into main Jun 8, 2026
1 check passed
@Pigbibi Pigbibi deleted the fix/dismiss-small-ibkr-dialog branch June 8, 2026 09:48

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 530922d6e0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread 2fa_bot.py
Comment on lines +40 to +42
DISMISS_SMALL_GATEWAY_DIALOGS = os.environ.get(
"IBKR_DISMISS_SMALL_GATEWAY_DIALOGS",
"yes",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Forward the new dismissal toggle into the container

In the normal deployment path the bot runs inside the compose service, but docker-compose.yml uses an explicit environment: list with no env_file, and the workflow env writer only emits the existing 2FA variables. As a result, setting IBKR_DISMISS_SMALL_GATEWAY_DIALOGS=no in the host .env or repo variables never reaches 2fa_bot.py, so operators cannot disable this new broad IBKR Gateway dialog dismissal without editing the compose file itself.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant