Skip to content

Support income layer start amount#177

Merged
Pigbibi merged 1 commit into
mainfrom
codex/income-layer-start-runtime-20260618
Jun 18, 2026
Merged

Support income layer start amount#177
Pigbibi merged 1 commit into
mainfrom
codex/income-layer-start-runtime-20260618

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • read INCOME_LAYER_START_USD from runtime environment
  • pass income_layer_start_usd into strategy runtime overrides
  • sync the new variable into Cloud Run environment

Tests

  • python -m py_compile runtime_config_support.py strategy_runtime.py
  • pytest targeted income-layer runtime/config tests
  • bash tests/test_sync_cloud_run_env_workflow.sh

@Pigbibi Pigbibi merged commit 8c7dbba into main Jun 18, 2026
1 check passed
@Pigbibi Pigbibi deleted the codex/income-layer-start-runtime-20260618 branch June 18, 2026 15:35

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0c5820c054

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread strategy_runtime.py
Comment on lines +174 to +175
if income_layer_start_usd is not None:
overrides["income_layer_start_usd"] = income_layer_start_usd

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Scope income layer start overrides to supported profiles

When INCOME_LAYER_START_USD is set for any deployment whose selected profile is not soxl_soxx_trend_income (for example tqqq_growth_income), this unconditional override is merged into the runtime config and then the vendored evaluate_tqqq_growth_income passes it through as **config to build_rebalance_plan, whose signature has no income_layer_start_usd parameter. That makes runtime evaluation fail with an unexpected-keyword TypeError instead of producing a rebalance plan, so this override should be gated to the profile(s) that actually accept it.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant