Skip to content

Bump UsEquityStrategies for IBIT DCA#178

Merged
Pigbibi merged 2 commits into
mainfrom
codex/bump-us-equity-ibit-20260618
Jun 18, 2026
Merged

Bump UsEquityStrategies for IBIT DCA#178
Pigbibi merged 2 commits into
mainfrom
codex/bump-us-equity-ibit-20260618

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • bump UsEquityStrategies to f92301b329ab5054ec5ed6fb8ce043b48ff18a0e
  • make ibit_smart_dca available to the platform runtime

Tests

  • git diff --check

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8f7607920f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread requirements.txt
gunicorn
quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@b846c9d777a450e95d23c264853997d671f47dd9
us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.git@d08492ea4b4055515606ae386e59a31a943a7fec
us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.git@f92301b329ab5054ec5ed6fb8ce043b48ff18a0e

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add translations before enabling IBIT

This pin enables the new ibit_smart_dca runtime profile from UsEquityStrategies, so SUPPORTED_STRATEGY_PROFILES will now include it, but notifications/telegram.py has no strategy_name_ibit_smart_dca entries alongside the other supported profile names. In that state build_strategy_display_name() falls back to the raw profile slug, and tests/test_notifications.py explicitly asserts every supported profile has non-slug zh/en display names, so CI will fail until the translations are added or the profile is kept out of the supported set.

Useful? React with 👍 / 👎.

@Pigbibi Pigbibi merged commit c3f10e1 into main Jun 18, 2026
1 check passed
@Pigbibi Pigbibi deleted the codex/bump-us-equity-ibit-20260618 branch June 18, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant