Skip to content

[codex] Add DCA runtime settings#183

Merged
Pigbibi merged 1 commit into
mainfrom
dca-runtime-settings
Jun 18, 2026
Merged

[codex] Add DCA runtime settings#183
Pigbibi merged 1 commit into
mainfrom
dca-runtime-settings

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Parse DCA_MODE and DCA_BASE_INVESTMENT_USD from runtime settings.
  • Map fixed/smart DCA settings to UsEquityStrategies runtime config.
  • Bump UsEquityStrategies dependency to 361338f60900182e3be535cd5fd2be2b9a07b422.

Validation

  • python3 -m py_compile runtime_config_support.py strategy_runtime.py tests/test_strategy_runtime.py
  • lightweight stub import check for _build_runtime_overrides DCA mapping

Note

  • Full local unittest run is blocked on this VPS by missing quant_platform_kit dependency.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 926147103d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread runtime_config_support.py
Comment on lines +296 to +297
dca_mode=_optional_dca_mode_env("DCA_MODE"),
dca_base_investment_usd=_optional_positive_float_env("DCA_BASE_INVESTMENT_USD"),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Wire DCA overrides into Cloud Run env sync

When these new DCA_MODE / DCA_BASE_INVESTMENT_USD settings are configured as GitHub environment variables and the standard .github/workflows/sync-cloud-run-env.yml workflow is used, they are never passed to Cloud Run: the workflow's optional override env block currently only exposes the income vars at lines 156-161, and the update/remove block only syncs those income vars at lines 934-955. As a result the new fields remain None in managed deployments unless operators manually edit the Cloud Run service outside the repo workflow, so the DCA runtime controls added here have no effect in the normal deployment path.

Useful? React with 👍 / 👎.

@Pigbibi Pigbibi merged commit 55a44ae into main Jun 18, 2026
1 check passed
@Pigbibi Pigbibi deleted the dca-runtime-settings branch June 18, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant