Skip to content

Pass reserved cash policy to strategy runtime#184

Merged
Pigbibi merged 1 commit into
mainfrom
reserved-cash-floor-policy
Jun 18, 2026
Merged

Pass reserved cash policy to strategy runtime#184
Pigbibi merged 1 commit into
mainfrom
reserved-cash-floor-policy

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • pass positive reserved cash floor/ratio into strategy runtime overrides
  • update UsEquityStrategies dependency to 0cd90a37 with cash-reserve floor support
  • add regression coverage for runtime reserve policy overrides

Tests

  • PYTHONPATH=. timeout 180 /tmp/qsl-followup-pytest-venv-20260619/bin/python -m pytest tests/test_strategy_runtime.py::StrategyRuntimeTests::test_load_strategy_runtime_applies_reserved_cash_policy_overrides_from_settings
  • git diff --check

@Pigbibi Pigbibi force-pushed the reserved-cash-floor-policy branch from bbc0987 to 67ffcc7 Compare June 18, 2026 20:56
@Pigbibi Pigbibi merged commit 201e6c4 into main Jun 18, 2026
1 check passed
@Pigbibi Pigbibi deleted the reserved-cash-floor-policy branch June 18, 2026 20:58
@chatgpt-codex-connector

Copy link
Copy Markdown

💡 Codex Review

dca_mode=_optional_dca_mode_env("DCA_MODE"),
dca_base_investment_usd=_optional_positive_float_env("DCA_BASE_INVESTMENT_USD"),

P2 Badge Propagate DCA overrides through Cloud Run sync

When a DCA profile is configured via GitHub Environment variables, these new settings never reach Cloud Run: I checked .github/workflows/sync-cloud-run-env.yml, and the job maps/syncs the LongBridge runtime vars around lines 110-125 and 755-765 but has no DCA_MODE or DCA_BASE_INVESTMENT_USD entries. As a result these fields stay None after the normal sync workflow, so _apply_dca_runtime_overrides leaves live ibit_smart_dca/nasdaq_sp500_smart_dca on package defaults even when operators configure the new DCA vars in the deployment environment.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant