Skip to content

Remove TACO from crisis plugin#60

Merged
Pigbibi merged 2 commits into
mainfrom
fix/remove-legacy-taco-plugin-copy
May 16, 2026
Merged

Remove TACO from crisis plugin#60
Pigbibi merged 2 commits into
mainfrom
fix/remove-legacy-taco-plugin-copy

Conversation

@Pigbibi

@Pigbibi Pigbibi commented May 11, 2026

Copy link
Copy Markdown
Collaborator

Remove legacy TACO route/action handling from the crisis plugin translation path. User-facing notifications now use only generic crisis status wording.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c5d2ae011d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread notifications/telegram.py
Comment on lines 102 to 106
"strategy_plugin_route_no_action": "未触发危机",
"strategy_plugin_route_true_crisis": "真危机",
"strategy_plugin_route_taco_fake_crisis": "TACO 假危机",
"strategy_plugin_route_unknown_route": "未知状态",
"strategy_plugin_action_no_action": "不操作",
"strategy_plugin_action_watch_only": "仅通知",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve legacy crisis labels to avoid raw token leakage

Removing the strategy_plugin_route_taco_fake_crisis / strategy_plugin_action_small_taco entries causes legacy plugin payloads to render raw identifiers in Telegram notifications (taco_fake_crisis, small_taco) because translate_strategy_plugin_value falls back to the original value when a translation key is missing (application/runtime_strategy_adapters.py:50-54). This is user-visible whenever older crisis_response_shadow signal files are still mounted, so notifications can still expose TACO wording in a less readable form instead of a generic status/action.

Useful? React with 👍 / 👎.

@Pigbibi Pigbibi merged commit cdcaa95 into main May 16, 2026
1 check passed
@Pigbibi Pigbibi deleted the fix/remove-legacy-taco-plugin-copy branch May 16, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant