Skip to content

Use shared plugin email alert publisher#75

Merged
Pigbibi merged 1 commit into
mainfrom
qsl/plugin-email-alert-publisher
May 24, 2026
Merged

Use shared plugin email alert publisher#75
Pigbibi merged 1 commit into
mainfrom
qsl/plugin-email-alert-publisher

Conversation

@Pigbibi

@Pigbibi Pigbibi commented May 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • replace platform-local crisis email loops with the shared QPK strategy plugin email publisher
  • write sent/skipped/failed email diagnostics into runtime reports
  • pin QPK to ba67541711228f5a72a294def0e5cc24cc5479f3 from QuantPlatformKit PR Pin dynamic RSI strategy dependencies #47

Tests

  • python -m py_compile main.py
  • full pytest not run locally: this VPS environment is missing pandas

@Pigbibi Pigbibi force-pushed the qsl/plugin-email-alert-publisher branch from 4e5720c to 24f0f1f Compare May 24, 2026 17:21
@Pigbibi Pigbibi merged commit 39f9803 into main May 24, 2026
1 check passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4e5720c95e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread main.py
platform_id="longbridge",
strategy_profile=STRATEGY_PROFILE,
account_scope=ACCOUNT_REGION,
service_name=SECRET_NAME,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use runtime service name in alert context label

Build the alert context with the runtime service identity instead of SECRET_NAME; using service_name=SECRET_NAME makes deduplication keys depend on the token secret rather than the deployed service. When multiple deployments share the same strategy/account and secret (for example blue/green or parallel services writing to the same marker store prefix), one service can suppress another service’s alerts as duplicates. The runtime service identity is already available via RUNTIME_SETTINGS.runtime_target/Cloud Run K_SERVICE, so this field should not be set from the secret name.

Useful? React with 👍 / 👎.

@Pigbibi Pigbibi deleted the qsl/plugin-email-alert-publisher branch May 26, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant