Skip to content

Document Firstrade US equity platform support #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pigbibi merged 1 commit into from
May 20, 2026
Merged

Document Firstrade US equity platform support #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/platform_repo_boundaries.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ Examples today:
- `InteractiveBrokersPlatform`
- `CharlesSchwabPlatform`
- `LongBridgePlatform`
- `FirstradePlatform`
- `BinancePlatform`

These repositories are the actual deployment units.
Expand Down
7 changes: 5 additions & 2 deletions docs/us_equity_cross_platform_strategy_spec.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,13 @@

## Goal

All US equity strategies should be written once and be portable across the three
All US equity strategies should be written once and be portable across the
current broker runtimes:

- `ibkr`
- `schwab`
- `longbridge`
- `firstrade`

This document defines the contract new strategies must follow, and the migration
target existing strategies should converge to.
Expand Down Expand Up @@ -115,6 +116,7 @@ execution style:
- `ibkr`: native `weight`
- `schwab`: native `value`
- `longbridge`: native `value`
- `firstrade`: native `value`

Strategies must not implement broker-specific execution transforms themselves.

Expand Down Expand Up @@ -183,13 +185,14 @@ The platform runtime owns:

The strategy layer must not assume broker-local files or service-specific paths.

## Three-platform support rule
## Broker-platform support rule

For new US equity strategy profiles, the default expectation is:

- `ibkr` adapter present
- `schwab` adapter present
- `longbridge` adapter present
- `firstrade` adapter present

@chatgpt-codex-connector chatgpt-codex-connector Bot May 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Align required broker list with onboarding contract

Adding firstrade as a mandatory adapter in the support rule creates conflicting platform requirements across the docs: docs/us_equity_strategy_onboarding.md still defines a three-platform operating model (see lines 5, 18, and 97) and only documents IBKR/Schwab/LongBridge runtime env mapping. This inconsistency will cause strategy authors to follow incompatible checklists for supported_platforms and runtime readiness, which is likely to produce incorrect onboarding decisions unless the onboarding spec is updated in the same change.

Useful? React with 👍 / 👎.


If one platform is intentionally unsupported, the PR must include an explicit
reason and the profile must remain `eligible=false` there until the gap is
Expand Down
4 changes: 3 additions & 1 deletion docs/us_equity_execution_translation_spec.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,14 @@ Current native preferences are:
- `ibkr`: `weight`
- `schwab`: `value`
- `longbridge`: `value`
- `firstrade`: `value`

That means platform runtimes must support these translation paths:

- `weight -> value`
- needed for `schwab`
- needed for `longbridge`
- needed for `firstrade`
- `value -> weight`
- needed for `ibkr`

Expand Down Expand Up @@ -146,7 +148,7 @@ The blocked reason should appear in platform diagnostics or runtime reports.

- `global_etf_rotation`
- strategy contract is now `market_history` + `target_mode=weight`
- `schwab` / `longbridge` need `weight -> value`
- `schwab` / `longbridge` / `firstrade` need `weight -> value`
- `tqqq_growth_income`
- strategy contract is now canonical `value`
- `ibkr` needs `value -> weight`
Expand Down