Skip to content

Improve strategy plugin alert copy#59

Merged
Pigbibi merged 1 commit into
mainfrom
codex/improve-strategy-plugin-alert-copy
May 25, 2026
Merged

Improve strategy plugin alert copy#59
Pigbibi merged 1 commit into
mainfrom
codex/improve-strategy-plugin-alert-copy

Conversation

@Pigbibi

@Pigbibi Pigbibi commented May 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • format strategy plugin alert emails as mobile-friendly field lines
  • localize boolean values before rendering alert body
  • bump QuantPlatformKit to 0.7.27

Tests

  • PYTHONPATH=src python -m unittest tests/test_strategy_plugins.py -v
  • PYTHONPATH=src pytest tests/test_strategy_plugin_email_notifications.py tests/test_strategy_plugin_sms_notifications.py tests/test_strategy_plugin_alert_dispatcher.py tests/test_strategy_plugins.py
  • PYTHONPATH=src ruff check .

@Pigbibi Pigbibi merged commit a65f589 into main May 25, 2026
1 check passed
@Pigbibi Pigbibi deleted the codex/improve-strategy-plugin-alert-copy branch May 25, 2026 13:54

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cf308484c3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +523 to +525
"strategy_plugin_alert_plugin",
fallback="Plugin: {plugin}",
plugin=plugin,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep backward-compatible translation fallback for alert fields

In build_strategy_plugin_alert_messages, the alert body now relies on new keys (strategy_plugin_alert_plugin/status/action/mode) and no longer calls the existing strategy_plugin_line key that prior translators already implement. For deployments whose translator dictionaries were not updated in lockstep, these fields now fall back to hardcoded English, producing mixed-language alert bodies and a localization regression introduced by this commit. Consider preserving a compatibility path (e.g., fallback to strategy_plugin_line when the new keys are missing) so patch upgrades do not silently degrade translated alerts.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant