Skip to content

Hide live controls from public switch page #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pigbibi merged 1 commit into from
Jun 9, 2026
Merged

Hide live controls from public switch page #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion tests/strategy_switch_worker_validation.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,25 @@ assert.ok(indexHtml.includes(".switch-surface.summary-hidden"));
assert.ok(indexHtml.includes('summaryPanel.hidden = !showSummary'));
assert.ok(indexHtml.includes('switchSurface.classList.toggle("summary-hidden", !showSummary)'));
assert.equal(indexHtml.includes("publicSummary"), false);
assert.ok(indexHtml.includes("function hasPrivateConfig()"));
assert.ok(indexHtml.includes('el("quick-form").hidden = !showPrivateControls'));
assert.equal(indexHtml.includes("u15998061"), false);
assert.equal(indexHtml.includes("longbridge-quant-sg-service"), false);
assert.equal(indexHtml.includes('account_selector: "SG"'), false);
assert.match(indexHtml, /body\.app-loading \.shell\s*\{\s*display: none;/);

const servedPageResponse = await worker.fetch(new Request("https://switch.example/"), {});
const servedHtml = await servedPageResponse.text();
assert.equal(servedPageResponse.status, 200);
assert.ok(servedHtml.includes("function hasPrivateConfig()"));
assert.equal(servedHtml.includes("u15998061"), false);
assert.equal(servedHtml.includes("longbridge-quant-sg-service"), false);
assert.equal(servedHtml.includes('account_selector: "SG"'), false);

const publicConfigResponse = await worker.fetch(new Request("https://switch.example/api/config"), {});
assert.equal(publicConfigResponse.status, 200);
assert.deepEqual(await publicConfigResponse.json(), { accountOptions: null });

const headers = __test.responseHeaders({ "Content-Type": "text/html; charset=utf-8" });
assert.equal(headers.get("X-Frame-Options"), "DENY");
assert.equal(headers.get("X-Content-Type-Options"), "nosniff");
Expand Down Expand Up @@ -63,7 +80,7 @@ assert.equal(unauthorizedSyncResponse.status, 401);
assert.match((await unauthorizedSyncResponse.json()).error, /internal sync token is invalid/);

assert.equal(
await __test.withTimeout(new Promise((resolve) => setTimeout(() => resolve("late"), 25)), 1, "fallback"),
await __test.withTimeout(new Promise(() => {}), 1, "fallback"),
"fallback",
);

Expand Down
98 changes: 48 additions & 50 deletions web/strategy-switch-console/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,6 +469,13 @@
padding-top: 2px;
}

.public-note {
color: var(--muted);
font-size: 14px;
line-height: 1.55;
max-width: 560px;
}

.run-button {
min-height: 56px;
border: 0;
Expand Down Expand Up @@ -705,7 +712,9 @@ <h2 data-i18n="bootTitle">读取策略配置</h2>
<h2 id="platform-title">LongBridge</h2>
</div>

<div class="quick-form">
<p class="public-note" id="public-note" hidden data-i18n="publicReadonly">登录后查看账号配置。</p>

<div class="quick-form" id="quick-form">
<label class="control-block">
<span data-i18n="account">目标账号</span>
<select id="account-select"></select>
Expand All @@ -727,7 +736,7 @@ <h2 id="platform-title">LongBridge</h2>
</div>
</div>

<div class="run-area">
<div class="run-area" id="run-area">
<button class="run-button" id="dispatch-button" type="button" disabled data-i18n="loginToRun">登录后切换</button>
<p class="action-note" id="action-note">登录后才可执行切换。</p>
<p class="toast" id="toast" aria-live="polite"></p>
Expand Down Expand Up @@ -781,50 +790,16 @@ <h2 data-i18n="summary">切换摘要</h2>

const defaultAccountOptions = {
longbridge: [
{ key: "hk", label: "hk", target_name: "hk", account_selector: "HK", default_strategy_profile: "hk_low_vol_dividend_quality_snapshot", supported_domains: ["us_equity", "hk_equity"] },
{ key: "sg", label: "sg", target_name: "sg", account_selector: "SG", default_strategy_profile: "soxl_soxx_trend_income", supported_domains: ["us_equity", "hk_equity"] },
{ key: "paper", label: "paper", target_name: "paper", account_selector: "PAPER", default_strategy_profile: "mega_cap_leader_rotation_top50_balanced", supported_domains: ["us_equity", "hk_equity"] },
{ key: "preview", label: "LongBridge", target_name: "preview", supported_domains: ["us_equity", "hk_equity"] },
],
ibkr: [
{
key: "u15998061",
label: "u15998061",
target_name: "u15998061",
account_selector: "U15998061",
deployment_selector: "live-u1599-tqqq",
account_scope: "live-u1599-tqqq",
service_name: "interactive-brokers-live-u1599-tqqq-service",
default_strategy_profile: "tqqq_growth_income",
supported_domains: ["us_equity", "hk_equity"],
},
{
key: "u16608560",
label: "u16608560",
target_name: "u16608560",
account_selector: "U16608560",
deployment_selector: "live-u1660-soxl",
account_scope: "live-u1660-soxl",
service_name: "interactive-brokers-live-u1660-soxl-service",
default_strategy_profile: "soxl_soxx_trend_income",
supported_domains: ["us_equity", "hk_equity"],
},
{
key: "u18336562",
label: "u18336562",
target_name: "u18336562",
account_selector: "U18336562",
deployment_selector: "live-u1833-smart-dca",
account_scope: "live-u1833-smart-dca",
service_name: "interactive-brokers-live-u1833-smart-dca-service",
default_strategy_profile: "nasdaq_sp500_smart_dca",
supported_domains: ["us_equity", "hk_equity"],
},
{ key: "preview", label: "IBKR", target_name: "preview", supported_domains: ["us_equity", "hk_equity"] },
],
schwab: [
{ key: "default", label: "default", target_name: "default", default_strategy_profile: "soxl_soxx_trend_income", supported_domains: ["us_equity"] },
{ key: "preview", label: "Schwab", target_name: "preview", supported_domains: ["us_equity"] },
],
firstrade: [
{ key: "default", label: "default", target_name: "default", default_strategy_profile: "mega_cap_leader_rotation_top50_balanced", supported_domains: ["us_equity"] },
{ key: "preview", label: "Firstrade", target_name: "preview", supported_domains: ["us_equity"] },
],
};

Expand Down Expand Up @@ -855,6 +830,7 @@ <h2 data-i18n="summary">切换摘要</h2>
configureAccounts: "配置账号后切换",
runSwitch: "一键切换",
readonlyNote: "登录后才可执行切换。",
publicReadonly: "登录后查看账号配置。",
loadingConfigNote: "正在读取账号配置和当前状态。",
missingConfigNote: "账号配置未加载，暂时不能执行。",
readyNote: "点击后会触发 workflow，并同步目标平台服务。",
Expand Down Expand Up @@ -902,6 +878,7 @@ <h2 data-i18n="summary">切换摘要</h2>
configureAccounts: "Configure accounts",
runSwitch: "Switch now",
readonlyNote: "Sign in to switch.",
publicReadonly: "Sign in to view account config.",
loadingConfigNote: "Reading account config and current state.",
missingConfigNote: "Account config is not loaded, so switching is disabled.",
readyNote: "This dispatches the workflow and syncs the target platform service.",
Expand Down Expand Up @@ -941,10 +918,10 @@ <h2 data-i18n="summary">切换摘要</h2>
currentStrategies: {},
configSource: "default",
forms: {
longbridge: { accountKey: "hk", strategy: "hk_low_vol_dividend_quality_snapshot", executionMode: "live" },
ibkr: { accountKey: "u15998061", strategy: "tqqq_growth_income", executionMode: "live" },
schwab: { accountKey: "default", strategy: "soxl_soxx_trend_income", executionMode: "live" },
firstrade: { accountKey: "default", strategy: "mega_cap_leader_rotation_top50_balanced", executionMode: "live" },
longbridge: { accountKey: "preview", strategy: "", executionMode: "live" },
ibkr: { accountKey: "preview", strategy: "", executionMode: "live" },
schwab: { accountKey: "preview", strategy: "", executionMode: "live" },
firstrade: { accountKey: "preview", strategy: "", executionMode: "live" },
},
};

Expand All @@ -963,6 +940,10 @@ <h2 data-i18n="summary">切换摘要</h2>
return options.find((option) => option.key === form.accountKey) || options[0];
}

function hasPrivateConfig() {
return Boolean(state.auth.allowed && state.configSource === "private");
}

function cleanStrategyProfile(value) {
const profile = String(value || "").trim();
return /^[a-z0-9._=-]{1,120}$/.test(profile) ? profile : "";
Expand Down Expand Up @@ -1220,6 +1201,7 @@ <h2 data-i18n="summary">切换摘要</h2>
function renderPlatforms() {
const strip = el("platform-strip");
strip.replaceChildren();
const showPrivateConfig = hasPrivateConfig();
for (const platform of Object.keys(platformMeta)) {
ensureAccountSelection(platform);
const meta = platformMeta[platform];
Expand All @@ -1237,11 +1219,14 @@ <h2 data-i18n="summary">切换摘要</h2>
copyNode.className = "platform-copy";
const labelNode = document.createElement("strong");
labelNode.textContent = meta.label;
const accountNode = document.createElement("span");
accountNode.textContent = account.label;
const strategyNode = document.createElement("small");
strategyNode.textContent = strategyLabel(form.strategy);
copyNode.append(labelNode, accountNode, strategyNode);
copyNode.append(labelNode);
if (showPrivateConfig) {
const accountNode = document.createElement("span");
accountNode.textContent = account.label;
const strategyNode = document.createElement("small");
strategyNode.textContent = strategyLabel(form.strategy);
copyNode.append(accountNode, strategyNode);
}
button.append(mark, copyNode);
strip.appendChild(button);
}
Expand All @@ -1256,9 +1241,22 @@ <h2 data-i18n="summary">切换摘要</h2>
const choices = strategyChoicesForAccount(platform, account);
const accountSelect = el("account-select");
const strategySelect = el("strategy-select");
const showPrivateControls = hasPrivateConfig();

el("switch-panel").style.setProperty("--platform-color", meta.accent);
el("platform-title").textContent = meta.label;
el("quick-form").hidden = !showPrivateControls;
el("run-area").hidden = !showPrivateControls;
el("public-note").hidden = showPrivateControls;
el("public-note").textContent = state.auth.allowed ? t("missingConfigNote") : t("publicReadonly");

if (!showPrivateControls) {
accountSelect.replaceChildren();
strategySelect.replaceChildren();
el("account-meta").textContent = "";
el("strategy-meta").textContent = "";
return;
}

accountSelect.replaceChildren();
if (accounts.length) {
Expand Down Expand Up @@ -1292,7 +1290,7 @@ <h2 data-i18n="summary">切换摘要</h2>
}

function renderSummary() {
const showSummary = Boolean(state.auth.allowed);
const showSummary = hasPrivateConfig();
const summaryPanel = document.querySelector(".summary-panel");
const switchSurface = document.querySelector(".switch-surface");
summaryPanel.hidden = !showSummary;
Expand Down
2 changes: 1 addition & 1 deletion web/strategy-switch-console/page_asset.js
View file
Open in desktop

Large diffs are not rendered by default.