Skip to content

Align contributing checks with CI #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pigbibi merged 1 commit into from
Jun 9, 2026
Merged

Align contributing checks with CI #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ Run the lightweight whitespace check for every change and the repository test co

```bash
git diff --check
python -m pytest -q
python3 scripts/runtime_settings.py validate
python3 -m unittest discover -s tests -v

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Include web asset validation in local checks

For changes under web/strategy-switch-console, this documented local test set still does not match CI: .github/workflows/validate.yml runs sync_strategy_switch_page_asset.py, checks generated asset diffs/JQ, executes tests/strategy_switch_worker_validation.mjs, and runs Node syntax checks, but the new instructions stop after Python unittest discovery. Contributors following this section can miss failures that the Validate strategy switch web assets CI step will reject, especially because unittest discovery will not execute the .mjs test.

Useful? React with 👍 / 👎.

```

For documentation-only changes, at minimum review Markdown links, headings, and bilingual consistency before opening the pull request.