Skip to content

Expose live-gated option overlay profile metadata#73

Merged
Pigbibi merged 1 commit into
mainfrom
codex/strategy-switch-option-overlay-metadata
Jun 22, 2026
Merged

Expose live-gated option overlay profile metadata#73
Pigbibi merged 1 commit into
mainfrom
codex/strategy-switch-option-overlay-metadata

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add option overlay defaults and promotion-gate metadata to strategy profile catalog
  • preserve option overlay metadata through worker profile normalization while still rejecting manual option overrides
  • regenerate bundled strategy profile assets and update docs/tests

Tests

  • python3 scripts/runtime_settings.py validate
  • python3 -m unittest tests.test_runtime_settings -v
  • node --experimental-default-type=module tests/strategy_switch_worker_validation.mjs
  • git diff --check

@Pigbibi Pigbibi merged commit 4345c95 into main Jun 22, 2026
2 checks passed
@Pigbibi Pigbibi deleted the codex/strategy-switch-option-overlay-metadata branch June 22, 2026 21:11

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 970b5da92d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ibit_zscore_exit_controls = _extract_ibit_zscore_exit_control_fields(extra_variables)
_reject_direct_dca_extra_variables(extra_variables)
_reject_direct_ibit_zscore_exit_extra_variables(extra_variables)
_reject_research_only_extra_variables(extra_variables)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reject nested research-only variables in service-target patches

This rejection only inspects the top-level extra_variables parsed from the new request. In the IBKR auto path, an existing CLOUD_RUN_SERVICE_TARGETS_JSON is loaded below and _patch_service_targets() writes {**entry, **replacement}, so any existing INCOME_THRESHOLD_USD/OPTION_* fields inside the matched service-target entry are carried into the new target without validation; I verified a target with existing INCOME_THRESHOLD_USD still builds and renders it under CLOUD_RUN_SERVICE_TARGETS_JSON. That leaves the research-only settings stored live despite this new gate, so the nested service-target entry needs to be filtered or validated too.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant