Skip to content

Conversation

@czareko
Copy link
Collaborator

@czareko czareko commented Jan 29, 2026

No description provided.

@czareko czareko marked this pull request as ready for review January 29, 2026 08:26
@czareko czareko changed the title feat: HS for Multisig feat: High-Security Integration for Multisig Pallet Jan 29, 2026
@n13
Copy link
Collaborator

n13 commented Jan 29, 2026

Gemini Review:
Architecture: The pallet-multisig now has a hard dependency on pallet-reversible-transfers for the HighSecurityInspector trait. I recommended inverting this dependency by defining the trait within pallet-multisig to keep the pallet generic.

Security: The implementation includes good defense-in-depth measures, such as checking call size before decoding. The documentation regarding the "Risk Window" during migration is clear and helpful.

Code Quality: The refactoring in transaction_extensions.rs to share the whitelist logic with the multisig configuration is excellent.

1. Architecture & Dependency Management

Observation: pallet-multisig now depends on pallet-reversible-transfers to access the HighSecurityInspector trait.

  • pallets/multisig/Cargo.toml adds pallet-reversible-transfers.
  • pallets/multisig/src/lib.rs imports the trait from pallet-reversible-transfers.

Recommendation: Invert this dependency to keep pallet-multisig generic and decoupled from specific business logic pallets.

  • Action: Define the HighSecurityInspector trait directly inside pallet-multisig (e.g., in traits.rs or lib.rs).
  • Benefit: pallet-multisig will no longer depend on pallet-reversible-transfers. The Runtime will bridge the two by implementing the trait (as it already does in runtime/src/configs/mod.rs), but the trait definition will live in the consumer (multisig) or a shared primitives crate, not the provider (reversible-transfers).

It kinda makes sense ^^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants