Skip to content

Conversation

@n13
Copy link
Collaborator

@n13 n13 commented Jan 30, 2026

  • All screens are functional
  • Gradients OK
Simulator Screenshot - iPhone 17 - 2026-01-30 at 23 18 00 Simulator Screenshot - iPhone 17 - 2026-01-30 at 23 18 20 Simulator Screenshot - iPhone 17 - 2026-01-30 at 23 18 37 Simulator Screenshot - iPhone 17 - 2026-01-30 at 23 18 49

@n13 n13 requested a review from dewabisma January 30, 2026 13:10
@n13 n13 changed the title Requests Screens Refactor [Draft] Requests Screens Refactor Jan 30, 2026
);
}

Widget _buildLinkButton() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link button, I think it will be good if we add this to the button variant if we reuse this

} catch (e) {
if (mounted) {
setState(() => _isUnlinking = false);
ScaffoldMessenger.of(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use context.showErrorSnackbar

}

return null;
String _formatTimeAgo(String url) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this for?

),
),
Text(
_formatTimeAgo(url),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh this used here, but the implementation is not added yet

required this.pink,
required this.yellow,
required this.background,
required this.background2,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You added it but not using it at all

Copy link
Collaborator

@dewabisma dewabisma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one critical issue I found, the formatTimeAgo implementation is not added yet it just return empty string currently.

Other than that, mainly we keep using magic code for color and font style, I see it keep repeating color and font style, why we don't have it in theme style?

@dewabisma
Copy link
Collaborator

You can get the rank stats in referral by querying GET /addresses/leaderboard?referral_code=<code> it will give result like below

{
    "data": [
        {
            "address": {
                "quan_address": "qzkzyez9vMXtG9zti4Y8yzH2z1hU2UQhYAVnyt7mGJHUi4yhp",
                "referral_code": "sauce-service-else-honey-monitor",
                "referrals_count": 43,
                "updated_at": "2025-11-30T03:24:42.192018Z",
                "created_at": "2025-11-19T13:59:46.636844Z"
            },
            "rank": 1
        },
    ],
    "meta": {
        "page": 1,
        "page_size": 25,
        "total_items": 1,
        "total_pages": 1
    }
}

@dewabisma
Copy link
Collaborator

Also, I just realized we have input for bio? what is it for? We already check the bio in server we don't need to have bio form

@n13
Copy link
Collaborator Author

n13 commented Jan 31, 2026

Also, I just realized we have input for bio? what is it for? We already check the bio in server we don't need to have bio form

yeah the design should be a checkbox maybe? IDK.

@n13
Copy link
Collaborator Author

n13 commented Jan 31, 2026

There is one critical issue I found, the formatTimeAgo implementation is not added yet it just return empty string currently.

Other than that, mainly we keep using magic code for color and font style, I see it keep repeating color and font style, why we don't have it in theme style?

I think this is one of the last updates we make to this version of the app and it doesn't really matter. New app version will look different.

So magic styles are ok, although I will see if we don't already have some of these colors and use them as good practice.

Hacks still not ok btw

@dewabisma
Copy link
Collaborator

Okay, maybe we just don't display the time ago, because the endpoint only return the link not the timestamp of created. We don't want to bother with it because we will remove it anyway.

Copy link
Collaborator

@dewabisma dewabisma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, it works and displayed good. I guess since we will remove it anyway let's not add too much effort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants