-
Notifications
You must be signed in to change notification settings - Fork 1
Requests Screens Refactor #375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
mobile-app/lib/features/components/complete_setup_action_sheet.dart
Outdated
Show resolved
Hide resolved
mobile-app/lib/features/main/screens/quests/complete_setup_action_sheet.dart
Outdated
Show resolved
Hide resolved
mobile-app/lib/features/components/complete_setup_action_sheet.dart
Outdated
Show resolved
Hide resolved
mobile-app/lib/features/main/screens/quests/complete_setup_action_sheet.dart
Show resolved
Hide resolved
mobile-app/lib/features/main/screens/quests/complete_setup_action_sheet.dart
Show resolved
Hide resolved
| ); | ||
| } | ||
|
|
||
| Widget _buildLinkButton() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link button, I think it will be good if we add this to the button variant if we reuse this
| } catch (e) { | ||
| if (mounted) { | ||
| setState(() => _isUnlinking = false); | ||
| ScaffoldMessenger.of( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use context.showErrorSnackbar
| } | ||
|
|
||
| return null; | ||
| String _formatTimeAgo(String url) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this for?
mobile-app/lib/features/main/screens/quests/king_of_the_shill_screen.dart
Show resolved
Hide resolved
| ), | ||
| ), | ||
| Text( | ||
| _formatTimeAgo(url), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh this used here, but the implementation is not added yet
| required this.pink, | ||
| required this.yellow, | ||
| required this.background, | ||
| required this.background2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You added it but not using it at all
dewabisma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one critical issue I found, the formatTimeAgo implementation is not added yet it just return empty string currently.
Other than that, mainly we keep using magic code for color and font style, I see it keep repeating color and font style, why we don't have it in theme style?
|
You can get the rank stats in referral by querying |
|
Also, I just realized we have input for bio? what is it for? We already check the bio in server we don't need to have bio form |
yeah the design should be a checkbox maybe? IDK. |
I think this is one of the last updates we make to this version of the app and it doesn't really matter. New app version will look different. So magic styles are ok, although I will see if we don't already have some of these colors and use them as good practice. Hacks still not ok btw |
|
Okay, maybe we just don't display the time ago, because the endpoint only return the link not the timestamp of created. We don't want to bother with it because we will remove it anyway. |
dewabisma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, it works and displayed good. I guess since we will remove it anyway let's not add too much effort
Uh oh!
There was an error while loading. Please reload this page.