Add top-like monitoring tool#333
Draft
ben-grande wants to merge 1 commit into
Draft
Conversation
Member
Do you mean read() hangs for you? Maybe the service waits for something before starting to output any data (doesn't look like it based on the other PR...). |
Contributor
Author
|
Not the service by default, I prepended sleep to awk to test if a DomU
could hang operation on Dom0 and if this is a valid concern.
…On Tue, Jan 28, 2025, 12:25 PM Marek Marczykowski-Górecki < ***@***.***> wrote:
is a blocking operation as well as proc.stdout.read(2)
Do you mean read() hangs for you? Maybe the service waits for something
before starting to output any data (doesn't look like it based on the other
PR...).
—
Reply to this email directly, view it on GitHub
<#333 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BCE2O4LDOXXM2LA43ENCLQ32M5SKPAVCNFSM6AAAAABWAFNTCOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJYG4ZDGNBUG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Member
|
Based on discussion in the other PR, this should be converted to use stat events (and events extended to include necessary info). Converting to draft until then. |
75a9ee5 to
bc049c9
Compare
Contributor
Author
|
LLM helped on |
Inspiration and code from qui-domains. Known issues: - R4.2: scrolling works fast - R4.3: scrolling is slow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires: QubesOS/qubes-core-agent-linux#550
I did that, but it seems that it is difficult to limit the amount of bytes that can be read as
proc.communicate(timeout=1)is a blocking operation as well asproc.stdout.read(2)To ensure a domU doesn't fill up Dom0 memory that is being assigned to
untrusted_mem, something like this would have to be done: https://stackoverflow.com/a/34114767, unless someone knows a better solution.