Skip to content

Do not hide qubes-backup-restore working files#407

Merged
marmarek merged 1 commit into
QubesOS:mainfrom
alimirjamali:issue-10551
Jan 13, 2026
Merged

Do not hide qubes-backup-restore working files#407
marmarek merged 1 commit into
QubesOS:mainfrom
alimirjamali:issue-10551

Conversation

@alimirjamali

Copy link
Copy Markdown
Contributor

Also put them all together within a dedicated subdirectory nested in ~/QubesIncoming directory.

The mentioned tmp directory should be automatically cleaned up if the restore/verification operation is successful due to the patch for: QubesOS/qubes-issues#8307

resolves: QubesOS/qubes-issues#10551

Also put them all together within a dedicated subdirectory nested in
`~/QubesIncoming` directory.

The mentioned tmp directory should be automatically cleaned up if the
restore/verification operation is successful due to the patch for:
QubesOS/qubes-issues#8307

resolves: QubesOS/qubes-issues#10551
@marmarek

Copy link
Copy Markdown
Member

PipelineRetry

@codecov

codecov Bot commented Jan 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.20%. Comparing base (dcb1ec8) to head (1138e63).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
+ Coverage   76.16%   76.20%   +0.04%     
==========================================
  Files          53       53              
  Lines        9304     9340      +36     
==========================================
+ Hits         7086     7118      +32     
- Misses       2218     2222       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marmarek

Copy link
Copy Markdown
Member

The directory was renamed to hidden in #351, but I cannot find explanation why, looks like unintentional change.

@marmarek

Copy link
Copy Markdown
Member

The mentioned tmp directory should be automatically cleaned up if the restore/verification operation is successful due to the patch for: QubesOS/qubes-issues#8307

That issue was about App qubes, not dom0. The fix wasn't implemented in dom0 - but also, dom0 rarely has QubesIncoming directory - mostly (only?) after restoring a backup.

@marmarek marmarek merged commit ff2ba4d into QubesOS:main Jan 13, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

qubes-backup-restore maybe shouldn't hide the working files it places in ~/QubesIncoming

2 participants