qvm-start-daemon: skip GUI/AUDIO for dead domain#460
Conversation
|
PipelineRetryFailed |
|
See CI. |
therohityadav
force-pushed
the
fix-10793-qvm-start-daemon-dead-domain
branch
from
6d30dcb to
2921fe6
Compare
Avoid starting GUI/AUDIO when a domain has already terminated, resulting in invalid XID (-1). Add checks for VM running state and valid XID before spawning daemons. Fixes QubesOS/qubes-issues#10793
therohityadav
force-pushed
the
fix-10793-qvm-start-daemon-dead-domain
branch
from
2921fe6 to
fa79045
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #460 +/- ##
==========================================
+ Coverage 76.24% 76.31% +0.06%
==========================================
Files 53 53
Lines 9322 9410 +88
==========================================
+ Hits 7108 7181 +73
- Misses 2214 2229 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026040702-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026032404-devel&flavor=update
Failed tests20 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/170766#dependencies 28 fixed
Unstable testsDetailsPerformance TestsPerformance degradation:10 performance degradations
Remaining performance tests:101 tests
|
I thought this might be caused by this PR but it appears to happen without it. |
4 participants
Fixes QubesOS/qubes-issues#10793
qvm-start-daemonmay attempt to start GUI and AUDIO daemons for a domain that has already terminated early, resulting in an invalid XID (-1) being passed toqubes-guidandpacat-simple-vchan.Add checks to ensure the VM is still running and the XID is valid (>= 0) before spawning daemons. This prevents errors and handles race conditions where the domain terminates between event handling and daemon startup.