Skip to content

Add CI coverage for vmupdate formatting and pylint checks.#215

Open
nihalxkumar wants to merge 2 commits into
QubesOS:mainfrom
nihalxkumar:enable-ci-checks
Open

Add CI coverage for vmupdate formatting and pylint checks.#215
nihalxkumar wants to merge 2 commits into
QubesOS:mainfrom
nihalxkumar:enable-ci-checks

Conversation

@nihalxkumar

Copy link
Copy Markdown

This extends the existing GitLab test job so vmupdate changes are checked with black and pylint after the unit tests run.

The patch also formats the current vmupdate files so the new black check starts from a clean baseline, and adds a focused pylint configuration for the checks that are actionable in this tree.

Mypy is intentionally not enabled in this PR because current upstream still has existing typing errors that need a separate cleanup before it can be a blocking CI check.

fixes: #213 (comment)

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.74%. Comparing base (6786ad4) to head (aa2ca20).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
+ Coverage   71.72%   71.74%   +0.02%     
==========================================
  Files          12       12              
  Lines        1337     1338       +1     
==========================================
+ Hits          959      960       +1     
  Misses        378      378              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread .gitlab-ci.yml
script:
- export PATH="$HOME/.local/bin:$PATH"
- PYTHONPATH=~/core-admin-client ./run-tests.sh
- python3 -m black -l80 --check setup.py vmupdate

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have some template jobs for this already. Try:

include:
- file: /common.yml
  project: QubesOS/qubes-continuous-integration

...
lint:
  extends: .lint
  stage: checks
  variables:
    DIR: vmupdate

if pylint needs to be custom anyway, you can add SKIP_PYLINT: 1 here and keep pylint as you do now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants