Add CI coverage for vmupdate formatting and pylint checks.#215
Open
nihalxkumar wants to merge 2 commits into
Open
Add CI coverage for vmupdate formatting and pylint checks.#215nihalxkumar wants to merge 2 commits into
nihalxkumar wants to merge 2 commits into
Conversation
aed978a to
aa2ca20
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #215 +/- ##
==========================================
+ Coverage 71.72% 71.74% +0.02%
==========================================
Files 12 12
Lines 1337 1338 +1
==========================================
+ Hits 959 960 +1
Misses 378 378 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
marmarek
reviewed
Jun 9, 2026
| script: | ||
| - export PATH="$HOME/.local/bin:$PATH" | ||
| - PYTHONPATH=~/core-admin-client ./run-tests.sh | ||
| - python3 -m black -l80 --check setup.py vmupdate |
Member
There was a problem hiding this comment.
We have some template jobs for this already. Try:
include:
- file: /common.yml
project: QubesOS/qubes-continuous-integration
...
lint:
extends: .lint
stage: checks
variables:
DIR: vmupdate
if pylint needs to be custom anyway, you can add SKIP_PYLINT: 1 here and keep pylint as you do now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extends the existing GitLab test job so vmupdate changes are checked with black and pylint after the unit tests run.
The patch also formats the current vmupdate files so the new black check starts from a clean baseline, and adds a focused pylint configuration for the checks that are actionable in this tree.
Mypy is intentionally not enabled in this PR because current upstream still has existing typing errors that need a separate cleanup before it can be a blocking CI check.
fixes: #213 (comment)