Fix changing default_netvm#716
Conversation
Do not exclude network-providing qubes when checking if changing default_netvm is allowed.
Avoid collision with similar function in dvmtemplate mixin.
Do not duplicate the check if changing to non-running netvm. But more importantly, call the property-pre-set event to unset old netvm. Otherwise setting the new one will fail (property-reset:netvm handler assumes matching pre-(re)set handler detached old value already). DO not use property-pre-reset:netvm here, because it can't know the new value yet (pre-reset is used when changing non-default to default value, so normally it can check what is the default value at the call time - but here it wouldn't work because the default value is going to change). Fixes QubesOS/qubes-issues#10125
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #716 +/- ##
==========================================
+ Coverage 70.47% 70.59% +0.12%
==========================================
Files 61 61
Lines 13560 13561 +1
==========================================
+ Hits 9557 9574 +17
+ Misses 4003 3987 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Check if attach/detach network functions are called. QubesOS/qubes-issues#10125
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025080809-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025061004-4.3&flavor=update
Failed tests15 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/142375#dependencies 11 fixed
Unstable testsDetailsPerformance TestsPerformance degradation:3 performance degradations
Remaining performance tests:130 tests
|
2 participants
Reduce code duplication by calling the same events as on normal netvm change. Especially, this fixes missing detaching old netvm before attaching new one.
Fixes QubesOS/qubes-issues#10125