Skip to content

Allow qube to reboot upon its request#810

Draft
ben-grande wants to merge 4 commits into
QubesOS:mainfrom
ben-grande:reboot
Draft

Allow qube to reboot upon its request#810
ben-grande wants to merge 4 commits into
QubesOS:mainfrom
ben-grande:reboot

Conversation

@ben-grande

@ben-grande ben-grande commented May 19, 2026

Copy link
Copy Markdown
Contributor

Fixes: QubesOS/qubes-issues#8196


Missing some method to make qmemman hold the memory of the domain and not redistribute it (until timeout is reached).


Rusty Bird note about the default: If True, a malicious qube can exceed the revisions_to_keep by keeping rebooting, and prevent restoration to a known good state. See linked issue for the dicussion.


  • ran OpenQA on my runner
  • rebooted HVM, TemplateVMs and StandaloneVMs but required libvirt_domain.destroy():
    • Windows 11
    • Ubuntu Desktop 26.04
    • OpenBSD 7.9
    • fedora-, debian- (Any TemplateVM)

@ben-grande ben-grande force-pushed the reboot branch 7 times, most recently from f85154d to 642d09a Compare May 20, 2026 13:54
@codecov

codecov Bot commented May 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 23.52941% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.17%. Comparing base (71b5ab2) to head (6649f40).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
qubes/vm/qubesvm.py 32.00% 17 Missing ⚠️
qubes/app.py 0.00% 5 Missing ⚠️
qubes/tools/qmemmand.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #810      +/-   ##
==========================================
- Coverage   70.24%   70.17%   -0.07%     
==========================================
  Files          61       61              
  Lines       14073    14097      +24     
==========================================
+ Hits         9885     9893       +8     
- Misses       4188     4204      +16     
Flag Coverage Δ
unittests 70.17% <23.52%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ben-grande ben-grande force-pushed the reboot branch 2 times, most recently from ff09bb0 to 6649f40 Compare May 20, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make in-VM reboot request actually restart the VM

1 participant