api/internal: invalidate SystemInfoCache on domain-add and domain-delete#825
Open
alex-schose wants to merge 1 commit into
Open
api/internal: invalidate SystemInfoCache on domain-add and domain-delete#825alex-schose wants to merge 1 commit into
alex-schose wants to merge 1 commit into
Conversation
Member
|
PipelineRefresh |
Member
|
PipelineRetry |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #825 +/- ##
==========================================
- Coverage 70.46% 70.35% -0.12%
==========================================
Files 61 61
Lines 14144 14087 -57
==========================================
- Hits 9967 9911 -56
+ Misses 4177 4176 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
You must add |
Author
|
Done — updated to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SystemInfoCacheinvalidatescls.cachefor every event invm_events(via
event_handler), buton_domain_addandon_domain_deleteonlyregister / unregister the per-VM handlers - they never invalidate the cache
itself, and
vm_eventscontains neitherdomain-addnordomain-delete.As a result a freshly-created (or freshly-deleted) VM is missing from / stale
in the cached
system_infountil some other event happens to invalidate it.While stale, qubes-qrexec-policy-daemon's
internal.GetSystemInfoqueryreturns the old snapshot: a call naming a new VM logs
target '...' does not exist, using @default instead, and a deleted VM canstill be offered by a
@defaultaskhandler (e.g. qvm-copy).Fix: invalidate the cache in both handlers, after (un)registering the per-VM
handlers.
domain-add/domain-deleteare app-level events; this is thesymmetric counterpart to how every
vm_eventsentry already invalidates viaevent_handler. Performance impact is negligible - these events areinfrequent relative to the per-VM events that already clear the cache.
Fixes QubesOS/qubes-issues#10911.