Add distinct GUI bookmark package#633
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #633 +/- ##
==========================================
+ Coverage 70.30% 71.71% +1.41%
==========================================
Files 3 3
Lines 495 502 +7
==========================================
+ Hits 348 360 +12
+ Misses 147 142 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
marmarek
requested changes
May 13, 2026
marmarek
left a comment
marmarek
left a comment
Member
There was a problem hiding this comment.
Have you tried if the same mechanism works for GTK 4 too?
And also: referenced versions will need to be updated, but I can do that when merging.
| Replaces: qubes-core-agent (<< 4.0.0-1) | ||
| Breaks: qubes-core-agent (<< 4.0.0-1) | ||
| Description: Qubes integration for GUI bookmarks | ||
| GUI bookmarks for famous Qubes OS directories. |
Member
There was a problem hiding this comment.
I don't think "famous" is the word you are looking for. Maybe "common", or "useful"?
| Conflicts: qubes-core-vm < 4.0.0 | ||
|
|
||
| %description bookmark | ||
| GUI bookmarks for famous Qubes OS directories. |
Contributor
Author
No. With fedora-43-xfce thunar and nautilus still uses It seems that fedora-44 nautilus requires gtk4, but, uhm... it is the same for fedora-43. Using ** Message: 17:29:04.772: Connecting to org.freedesktop.Tracker3.Miner.Files
Unrecognized value "gl-disable". Try GDK_DEBUG=help
Unrecognized value "vulkan-disable". Try GDK_DEBUG=help
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/usr/lib64/python3.14/site-packages/gi/__init__.py", line 135, in require_version
raise ValueError(f"Namespace {namespace} not available for version {version}")
ValueError: Namespace Nautilus not available for version 4.0
<sys>:0: PyGIWarning: Nautilus was imported without specifying a version first. Use gi.require_version('Nautilus', '4.1') before import to ensure that the right version gets loaded.
GNOME nautilus 49.6Installing fedora-44 to test. |
Contributor
Author
Same thing on fedora-44-xfce with nautlius, gtk-4.0 dir is ignored and gtk-3.0 is used. By default, only the Do you want me to keep the bookmark in that directory? As it may be used in the future, even though I don't know an application that uses it. |
Member
Better not. Since it appears to be not used for now, we don't know if it will use the same format (if it will eventually be used at all). |
GTK bookmarks can be used by all currently supported file managers: - caja - thunar - nautilus - pcmanfm-qt (yes, it has a fallback for gtk bookmarks) For: QubesOS/qubes-issues#10081 Signed-off-by: Ben Grande <ben@invisiblethingslab.com>
This was referenced May 30, 2026
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026060617-devel&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update
Failed tests22 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/176874#dependencies 22 fixed
Unstable testsDetails
Performance TestsPerformance degradation:20 performance degradations
Remaining performance tests:91 tests
|
This was referenced May 30, 2026
Add disk2 status and update volume retrieval method
QubesOS/qubes-desktop-linux-i3-settings-qubes#23
Open
This was referenced Jun 2, 2026
tests: do not fail dispvm+thunderbird test early if TB is not installed
QubesOS/qubes-core-admin#817
Merged
marmarek
approved these changes
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GTK bookmarks can be used by all currently supported file managers:
For: QubesOS/qubes-issues#10081
Didn't name GTK because I wish to maintain it framework free. Because pcmanfm-qt is using GTK bookmark as fallback, there is currently no need for a QT workaround.