Always insert spaces into search bar#60
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
=======================================
Coverage 79.50% 79.50%
=======================================
Files 23 23
Lines 2561 2561
=======================================
Hits 2036 2036
Misses 525 525 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I think this is ok. Space is always a bit of a weird key.
that's a bit awkward, but as it shouldn't generally change search results if search later happens, I think it's ok?
That's a really good point. If you want to take a stab at that, feel free :) |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025071515-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025061004-4.3&flavor=update
Failed tests10 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/142375#dependencies 10 fixed
Unstable testsDetailsPerformance TestsPerformance degradation:7 performance degradations
Remaining performance tests:65 tests
|
4 participants
Fixes QubesOS/qubes-issues#8789. Follow up to #47, cc @marmarta. This combines elements of different versions of that PR.
Alternative: could let a focused search bar insert the space itself by wrapping all of this in in the previously present
Developed and tested on top of branch
release4.2.Tested scenarios from previous PR:
Still weird:
_key_pressand_key_pressedmethods appear to handle the same events. Combining them would make it easier to address the previous point.