Fixed ignored X property NET_WM_STATE_HIDDEN

[Ofenhed]

This seems to have been the original intent (see qubes-gui-daemon#d19a4a7), but as far as I can tell the VM side was never implemented.

I've only compared quickly, but it makes a huge difference because of the lack of GPU acceleration for VMs.

[qubesos-bot]

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025072915-4.3&flavor=pull-requests

Test run included the following:

• Add Arch packaging qubes-core-admin-client#332 (QubesOS/qubes-core-admin-client@40487bc)
• Add preload disposable setting to global config qubes-desktop-linux-manager#262 (QubesOS/qubes-desktop-linux-manager@26cdf14)
• Optimize SVG icons qubes-desktop-linux-menu#57 (QubesOS/qubes-desktop-linux-menu@aa4fdf6)
• Fixed ignored X property NET_WM_STATE_HIDDEN #241 (2733f0c)
• Connect vchan to GUI domain instead of dom0 qubes-gui-agent-windows#7 (QubesOS/qubes-gui-agent-windows@b904d94)
• Ignore RemoteVM for now qubes-manager#398 (QubesOS/qubes-manager@679eff4)
• Update PV drivers qubes-vmm-xen-windows-pvdrivers#4 (QubesOS/qubes-vmm-xen-windows-pvdrivers@531e058)
• rpm: build and package debug hypervisor qubes-vmm-xen#170 (QubesOS/qubes-vmm-xen@24e16a6)

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025061004-4.3&flavor=update

• system_tests_network_updates

  • TC_10_QvmTemplate_whonix-gateway-17: test_000_template_list (failure)
    qvm-template: error: No matching templates to list

  • TC_10_QvmTemplate_whonix-gateway-17: test_010_template_install (failure)
    qvm-template: error: Template 'debian-12-minimal' not found.

• system_tests_dispvm

  • TC_20_DispVM_debian-12-xfce: test_017_preload_autostart (failure)
    AssertionError: Lists differ: ['disp4642'] != []

  • TC_20_DispVM_fedora-42-xfce: test_017_preload_autostart (failure)
    AssertionError: Lists differ: ['disp1662'] != []

  • TC_20_DispVM_whonix-workstation-17: test_017_preload_autostart (failure)
    AssertionError: Lists differ: ['disp6278'] != []

  • TC_20_DispVM_whonix-workstation-17: test_030_edit_file (failure + cleanup)
    AssertionError: Timeout while waiting for disp[0-9]* window to show

  • TC_20_DispVM_whonix-workstation-17: test_100_open_in_dispvm (failure + cleanup)
    AssertionError: Timeout while waiting for disp[0-9]* window to show

• system_tests_basic_vm_qrexec_gui_zfs

  • TC_20_NonAudio_whonix-gateway-17-pool: test_401_long_window_title_utf8 (error + cleanup)
    raise TimeoutError from exc_val... TimeoutError

• system_tests_audio

  • TC_20_AudioVM_PipeWire_whonix-workstation-17: test_260_audio_mic_enabled_switch_audiovm (failure)
    AssertionError: 0 not greater than 0 : Failed to move-source-output

• system_tests_audio@hw1

  • TC_20_AudioVM_PipeWire_debian-12-xfce: test_250_audio_playback_audiovm_pipewire (error + cleanup)
    raise TimeoutError from exc_val... TimeoutError

  • TC_20_AudioVM_PipeWire_whonix-workstation-17: test_250_audio_playback_audiovm_pipewire (failure)
    AssertionError: pacat for test-inst-vm1 (xid 65) running(False) in ...

• system_tests_qwt_win10@hw13

  • windows_install: wait_serial (wait serial expected)
    # wait_serial expected: qr/tKcyh-\d+-/...

  • windows_install: Failed (test died + timed out)
    # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...

• system_tests_qwt_win10_seamless@hw13

  • windows_install: wait_serial (wait serial expected)
    # wait_serial expected: qr/4E4Ei-\d+-/...

  • windows_install: Failed (test died + timed out)
    # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...

Failed tests

17 failures

• system_tests_network_updates

  • TC_10_QvmTemplate_whonix-gateway-17: test_000_template_list (failure)
    qvm-template: error: No matching templates to list

  • TC_10_QvmTemplate_whonix-gateway-17: test_010_template_install (failure)
    qvm-template: error: Template 'debian-12-minimal' not found.

• system_tests_dispvm

  • TC_20_DispVM_debian-12-xfce: test_017_preload_autostart (failure)
    AssertionError: Lists differ: ['disp4642'] != []

  • TC_20_DispVM_fedora-42-xfce: test_017_preload_autostart (failure)
    AssertionError: Lists differ: ['disp1662'] != []

  • TC_20_DispVM_whonix-workstation-17: test_017_preload_autostart (failure)
    AssertionError: Lists differ: ['disp6278'] != []

  • TC_20_DispVM_whonix-workstation-17: test_030_edit_file (failure + cleanup)
    AssertionError: Timeout while waiting for disp[0-9]* window to show

  • TC_20_DispVM_whonix-workstation-17: test_100_open_in_dispvm (failure + cleanup)
    AssertionError: Timeout while waiting for disp[0-9]* window to show

• system_tests_kde_gui_interactive

  • gui_keyboard_layout: wait_serial (wait serial expected)
    # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...

  • gui_keyboard_layout: Failed (test died)
    # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...

• system_tests_basic_vm_qrexec_gui_zfs

  • TC_20_NonAudio_whonix-gateway-17-pool: test_401_long_window_title_utf8 (error + cleanup)
    raise TimeoutError from exc_val... TimeoutError

• system_tests_audio

  • TC_20_AudioVM_PipeWire_whonix-workstation-17: test_260_audio_mic_enabled_switch_audiovm (failure)
    AssertionError: 0 not greater than 0 : Failed to move-source-output

• system_tests_audio@hw1

  • TC_20_AudioVM_PipeWire_debian-12-xfce: test_250_audio_playback_audiovm_pipewire (error + cleanup)
    raise TimeoutError from exc_val... TimeoutError

  • TC_20_AudioVM_PipeWire_whonix-workstation-17: test_250_audio_playback_audiovm_pipewire (failure)
    AssertionError: pacat for test-inst-vm1 (xid 65) running(False) in ...

• system_tests_qwt_win10@hw13

  • windows_install: wait_serial (wait serial expected)
    # wait_serial expected: qr/tKcyh-\d+-/...

  • windows_install: Failed (test died + timed out)
    # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...

• system_tests_qwt_win10_seamless@hw13

  • windows_install: wait_serial (wait serial expected)
    # wait_serial expected: qr/4E4Ei-\d+-/...

  • windows_install: Failed (test died + timed out)
    # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/142375#dependencies

11 fixed

• system_tests_splitgpg

  • TC_10_Thunderbird_whonix-workstation-17: test_000_send_receive_default (failure)
    dogtail.tree.SearchError: descendent of [application | Thunderbird]...

  • TC_10_Thunderbird_whonix-workstation-17: test_010_send_receive_inline_signed_only (failure)
    dogtail.tree.SearchError: descendent of [application | Thunderbird]...

  • TC_10_Thunderbird_whonix-workstation-17: test_020_send_receive_inline_with_attachment (failure)
    dogtail.tree.SearchError: descendent of [application | Thunderbird]...

• system_tests_extra

  • TC_10_Thunderbird_whonix-workstation-17: test_000_send_receive_default (failure)
    dogtail.tree.SearchError: descendent of [application | Thunderbird]...

  • TC_10_Thunderbird_whonix-workstation-17: test_010_send_receive_inline_signed_only (failure)
    dogtail.tree.SearchError: descendent of [application | Thunderbird]...

  • TC_10_Thunderbird_whonix-workstation-17: test_020_send_receive_inline_with_attachment (failure)
    dogtail.tree.SearchError: descendent of [application | Thunderbird]...

  • TC_00_QVCTest_whonix-workstation-17: test_010_screenshare (failure)
    AssertionError: 1 != 0 : Timeout waiting for /dev/video0 in test-in...

• system_tests_audio

  • TC_20_AudioVM_Pulse_debian-12-xfce: test_252_audio_playback_audiovm_switch_hvm (failure)
    AssertionError: only silence detected, no useful audio data

  • TC_20_AudioVM_Pulse_whonix-workstation-17: test_225_audio_rec_unmuted_hvm (failure)
    AssertionError: too short audio, expected 10s, got 7.95233560090703...

• system_tests_guivm_vnc_gui_interactive

  • simple_gui_apps: unnamed test (unknown)
  • simple_gui_apps: Failed (test died)
    # Test died: no candidate needle with tag(s) 'vm-settings-applicati...

Unstable tests

Details

Performance Tests

Performance degradation:

6 performance degradations

• debian-12-xfce_exec-data-duplex-root: 79.83 🔺 ( previous job: 70.01, degradation: 114.02%)
• whonix-workstation-17_exec-data-duplex-root: 103.01 🔺 ( previous job: 86.00, degradation: 119.78%)
• dom0_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 7066.00 :small_red_triangle: ( previous job: 17102.00, degradation: 41.32%)
• dom0_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 7572.00 :small_red_triangle: ( previous job: 11086.00, degradation: 68.30%)
• dom0_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 58.00 :small_red_triangle: ( previous job: 1840.00, degradation: 3.15%)
• dom0_varlibqubes_seq1m_q8t1_read 3:read_bandwidth_kb: 100721.00 :small_red_triangle: ( previous job: 289182.00, degradation: 34.83%)

Remaining performance tests:

66 tests

• debian-12-xfce_exec: 8.26 🟢 ( previous job: 8.63, improvement: 95.78%)
• debian-12-xfce_exec-root: 29.38 🟢 ( previous job: 29.44, improvement: 99.82%)
• debian-12-xfce_socket: 8.74 🔺 ( previous job: 8.50, degradation: 102.80%)
• debian-12-xfce_socket-root: 8.56 🔺 ( previous job: 8.31, degradation: 102.98%)
• debian-12-xfce_exec-data-simplex: 67.95 🔺 ( previous job: 65.51, degradation: 103.72%)
• debian-12-xfce_exec-data-duplex: 71.00 🟢 ( previous job: 73.55, improvement: 96.54%)
• debian-12-xfce_socket-data-duplex: 162.68 🔺 ( previous job: 161.35, degradation: 100.82%)
• fedora-42-xfce_exec: 9.29
• fedora-42-xfce_exec-root: 58.01
• fedora-42-xfce_socket: 8.94
• fedora-42-xfce_socket-root: 8.16
• fedora-42-xfce_exec-data-simplex: 75.51
• fedora-42-xfce_exec-data-duplex: 76.24
• fedora-42-xfce_exec-data-duplex-root: 108.24
• fedora-42-xfce_socket-data-duplex: 139.95
• whonix-gateway-17_exec: 7.41 🔺 ( previous job: 7.34, degradation: 100.90%)
• whonix-gateway-17_exec-root: 40.04 🔺 ( previous job: 39.57, degradation: 101.18%)
• whonix-gateway-17_socket: 7.77 🟢 ( previous job: 7.85, improvement: 98.88%)
• whonix-gateway-17_socket-root: 7.17 🟢 ( previous job: 7.89, improvement: 90.86%)
• whonix-gateway-17_exec-data-simplex: 76.24 🟢 ( previous job: 77.76, improvement: 98.04%)
• whonix-gateway-17_exec-data-duplex: 79.28 🔺 ( previous job: 78.39, degradation: 101.14%)
• whonix-gateway-17_exec-data-duplex-root: 98.10 🔺 ( previous job: 90.74, degradation: 108.10%)
• whonix-gateway-17_socket-data-duplex: 174.33 🔺 ( previous job: 161.95, degradation: 107.65%)
• whonix-workstation-17_exec: 7.35 🟢 ( previous job: 8.27, improvement: 88.77%)
• whonix-workstation-17_exec-root: 53.91 🟢 ( previous job: 57.61, improvement: 93.58%)
• whonix-workstation-17_socket: 8.24 🟢 ( previous job: 8.97, improvement: 91.93%)
• whonix-workstation-17_socket-root: 7.77 🟢 ( previous job: 9.46, improvement: 82.14%)
• whonix-workstation-17_exec-data-simplex: 69.53 🟢 ( previous job: 74.54, improvement: 93.29%)
• whonix-workstation-17_exec-data-duplex: 76.66 🔺 ( previous job: 74.84, degradation: 102.44%)
• whonix-workstation-17_socket-data-duplex: 164.94 🔺 ( previous job: 160.20, degradation: 102.96%)
• dom0_root_seq1m_q8t1_read 3:read_bandwidth_kb: 474254.00 :green_circle: ( previous job: 289982.00, improvement: 163.55%)
• dom0_root_seq1m_q8t1_write 3:write_bandwidth_kb: 203557.00 :green_circle: ( previous job: 101988.00, improvement: 199.59%)
• dom0_root_seq1m_q1t1_read 3:read_bandwidth_kb: 408960.00 :green_circle: ( previous job: 14284.00, improvement: 2863.06%)
• dom0_root_seq1m_q1t1_write 3:write_bandwidth_kb: 195037.00 :green_circle: ( previous job: 32696.00, improvement: 596.52%)
• dom0_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 3424.00 :green_circle: ( previous job: 1091.00, improvement: 313.84%)
• dom0_varlibqubes_seq1m_q8t1_write 3:write_bandwidth_kb: 142449.00 :green_circle: ( previous job: 122848.00, improvement: 115.96%)
• dom0_varlibqubes_seq1m_q1t1_read 3:read_bandwidth_kb: 424181.00 :small_red_triangle: ( previous job: 433654.00, degradation: 97.82%)
• dom0_varlibqubes_seq1m_q1t1_write 3:write_bandwidth_kb: 182157.00 :green_circle: ( previous job: 167872.00, improvement: 108.51%)
• dom0_varlibqubes_rnd4k_q32t1_read 3:read_bandwidth_kb: 99202.00 :small_red_triangle: ( previous job: 108760.00, degradation: 91.21%)
• dom0_varlibqubes_rnd4k_q32t1_write 3:write_bandwidth_kb: 8066.00 :small_red_triangle: ( previous job: 8874.00, degradation: 90.89%)
• dom0_varlibqubes_rnd4k_q1t1_read 3:read_bandwidth_kb: 7944.00 :green_circle: ( previous job: 6356.00, improvement: 124.98%)
• dom0_varlibqubes_rnd4k_q1t1_write 3:write_bandwidth_kb: 4109.00 :small_red_triangle: ( previous job: 4420.00, degradation: 92.96%)
• fedora-42-xfce_root_seq1m_q8t1_read 3:read_bandwidth_kb: 366250.00
• fedora-42-xfce_root_seq1m_q8t1_write 3:write_bandwidth_kb: 238583.00
• fedora-42-xfce_root_seq1m_q1t1_read 3:read_bandwidth_kb: 288545.00
• fedora-42-xfce_root_seq1m_q1t1_write 3:write_bandwidth_kb: 54988.00
• fedora-42-xfce_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 93233.00
• fedora-42-xfce_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 2034.00
• fedora-42-xfce_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 8767.00
• fedora-42-xfce_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 1304.00
• fedora-42-xfce_private_seq1m_q8t1_read 3:read_bandwidth_kb: 393314.00
• fedora-42-xfce_private_seq1m_q8t1_write 3:write_bandwidth_kb: 141209.00
• fedora-42-xfce_private_seq1m_q1t1_read 3:read_bandwidth_kb: 317750.00
• fedora-42-xfce_private_seq1m_q1t1_write 3:write_bandwidth_kb: 65998.00
• fedora-42-xfce_private_rnd4k_q32t1_read 3:read_bandwidth_kb: 89705.00
• fedora-42-xfce_private_rnd4k_q32t1_write 3:write_bandwidth_kb: 4253.00
• fedora-42-xfce_private_rnd4k_q1t1_read 3:read_bandwidth_kb: 7895.00
• fedora-42-xfce_private_rnd4k_q1t1_write 3:write_bandwidth_kb: 680.00
• fedora-42-xfce_volatile_seq1m_q8t1_read 3:read_bandwidth_kb: 344133.00
• fedora-42-xfce_volatile_seq1m_q8t1_write 3:write_bandwidth_kb: 152221.00
• fedora-42-xfce_volatile_seq1m_q1t1_read 3:read_bandwidth_kb: 323534.00
• fedora-42-xfce_volatile_seq1m_q1t1_write 3:write_bandwidth_kb: 33495.00
• fedora-42-xfce_volatile_rnd4k_q32t1_read 3:read_bandwidth_kb: 77713.00
• fedora-42-xfce_volatile_rnd4k_q32t1_write 3:write_bandwidth_kb: 3651.00
• fedora-42-xfce_volatile_rnd4k_q1t1_read 3:read_bandwidth_kb: 8454.00
• fedora-42-xfce_volatile_rnd4k_q1t1_write 3:write_bandwidth_kb: 1055.00