Add boot mode support#407
Conversation
|
Figured out the bug. From a UX standpoint this seems done at least when doing a quick smoke test. Will do more thorough testing on this and QubesOS/qubes-core-admin#653 and hopefully mark as ready for review tomorrow. |
|
This is now ready for review. This should be merged with the corresponding backend PR, QubesOS/qubes-core-admin#653. |
|
Sigh, my Git acrobatics seems to have confused GitHub... |
|
Just fixed a label formatting issue. |
|
As a side effect you made the window quite tall. The basic one has a lot of padding at the bottom now, and similarly even on the advanced tab too. And the buttons don't fit on (small) screen: https://openqa.qubes-os.org/tests/131086#step/guivm_manager/27 |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025031404-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025021804-4.3&flavor=update
Failed tests25 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/129058#dependencies 10 fixed
Unstable testsDetailsPerformance TestsPerformance degradation:32 performance degradations
Remaining performance tests:40 tests
|
|
Self-review done, found and fixed some minor issues in qubes-manager and one issue that snuck by me in qubes-core-admin. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #407 +/- ##
==========================================
+ Coverage 68.55% 68.85% +0.30%
==========================================
Files 17 17
Lines 3762 3808 +46
==========================================
+ Hits 2579 2622 +43
- Misses 1183 1186 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The two lines that are failing to be covered by regression tests are lines I don't think the tests can cover with the current test design - they both would normally be triggered when the settings window was first opened. I can't patch the |
|
But you can have a VM with non-default boot mode, no? Just set the |
|
The value of the |
|
I mean the other not covered line. The one about |
|
ah, I see what you mean now (I had it in my head that both were in a similar situation but I see now that's not the case). I'll add another mockup and another testcase and see if I can get that one too. |
Boot modes provide a way for VMs to advertise that they can have their behavior changed by booting them with a predefined combination of additional kernel parameters set. This allows qubes to offer features like a secure system maintenance mode in a way that works seemlessly with Qubes OS. This commit adds boot mode support to Qubes Manager, allowing the user to view and select boot modes in the advanced tab of the settings dialog for each qube.
|
@marmarek I believe the addition to the tests you wanted is now added. |
4 participants
Adds the user interface elements described at QubesOS/qubes-issues#9750 (comment) to the settings UI.
Not fully tested, thus not ready for merge. It seems to work for the most part, but my PR for the backend has a problem that keeps me from changing AppVM's templates for some reason.