Communicate path character limits in GUI tools#451
Open
Jayant-kernel wants to merge 2 commits into
Open
Conversation
af3e04f to
b0d222e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #451 +/- ##
==========================================
+ Coverage 69.73% 70.86% +1.13%
==========================================
Files 17 17
Lines 4015 4030 +15
==========================================
+ Hits 2800 2856 +56
+ Misses 1215 1174 -41 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
7126d3e to
54d1f6a
Compare
54d1f6a to
6e52dab
Compare
Contributor
Author
|
@marmarta |
Member
|
Have you tested this? I tried to run it on a test system and I have not seen any effect (namely, VM settings still fails silently and crashes to death if I manually input a wrong path, backup allows me to proceed and then tells me it couldn't write the backup to file). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes QubesOS/qubes-issues#6943.
What changed
qubes.SelectFileandqubes.SelectDirectory.get_path_from_vm()raise that message for non-ASCII paths and other unsupported characters.Validation
python -m py_compile qubesmanager\utils.py qubesmanager\backup_utils.py qubesmanager\backup.py qubesmanager\bootfromdevice.py qubesmanager\tests\test_utils.py qubesmanager\tests\test_backup_utils.py qubesmanager\tests\test_bootfromdevice.pygit diff --check