Skip to content

Communicate path character limits in GUI tools#451

Open
Jayant-kernel wants to merge 2 commits into
QubesOS:mainfrom
Jayant-kernel:codex/path-character-hints
Open

Communicate path character limits in GUI tools#451
Jayant-kernel wants to merge 2 commits into
QubesOS:mainfrom
Jayant-kernel:codex/path-character-hints

Conversation

@Jayant-kernel

@Jayant-kernel Jayant-kernel commented May 31, 2026

Copy link
Copy Markdown
Contributor

Fixes QubesOS/qubes-issues#6943.

What changed

  • Added a shared translated message for path character limits used by qubes.SelectFile and qubes.SelectDirectory.
  • Made get_path_from_vm() raise that message for non-ASCII paths and other unsupported characters.
  • Added the same path-limit hint as a tooltip in Backup and Boot Qube From Device.
  • Updated Backup and Boot Qube From Device to show the clearer warning when remote path selection returns unsupported characters.
  • Added focused tests for accepted paths, invalid paths, Backup warning handling, and Boot Qube From Device tooltip/warning coverage.

Validation

  • python -m py_compile qubesmanager\utils.py qubesmanager\backup_utils.py qubesmanager\backup.py qubesmanager\bootfromdevice.py qubesmanager\tests\test_utils.py qubesmanager\tests\test_backup_utils.py qubesmanager\tests\test_bootfromdevice.py
  • git diff --check

@Jayant-kernel Jayant-kernel marked this pull request as ready for review May 31, 2026 14:52
@Jayant-kernel Jayant-kernel force-pushed the codex/path-character-hints branch from af3e04f to b0d222e Compare May 31, 2026 15:40
@codecov

codecov Bot commented May 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.86%. Comparing base (efff1ef) to head (2f2f4b5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #451      +/-   ##
==========================================
+ Coverage   69.73%   70.86%   +1.13%     
==========================================
  Files          17       17              
  Lines        4015     4030      +15     
==========================================
+ Hits         2800     2856      +56     
+ Misses       1215     1174      -41     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Jayant-kernel Jayant-kernel force-pushed the codex/path-character-hints branch 2 times, most recently from 7126d3e to 54d1f6a Compare June 2, 2026 06:01
@Jayant-kernel Jayant-kernel force-pushed the codex/path-character-hints branch from 54d1f6a to 6e52dab Compare June 2, 2026 06:18
@Jayant-kernel

Copy link
Copy Markdown
Contributor Author

@marmarta
review the changes , once free

@marmarta

marmarta commented Jun 8, 2026

Copy link
Copy Markdown
Member

Have you tested this? I tried to run it on a test system and I have not seen any effect (namely, VM settings still fails silently and crashes to death if I manually input a wrong path, backup allows me to proceed and then tells me it couldn't write the backup to file).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Communicate better limitations on characters in file paths in gui tools

2 participants