Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/remote/query-loader.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ export class QueryLoader extends EventEmitter<QueryLoaderEvents> {
this.scheduleNextPoll();
}
}, (error) => {
console.error(error);
// we don't expect an error here. Better signal our exit
this.emit("exit");
});
Expand Down
4 changes: 0 additions & 4 deletions src/remote/remote.ts
Original file line number Diff line number Diff line change
Expand Up @@ -174,14 +174,12 @@ export class Remote extends EventEmitter<RemoteEvents> {
(results) => results.diffs,
(error) => {
log.error("Failed to poll schema", "remote");
console.error(error);
throw error;
},
) ??
[] as Op[], /* no panic in case schemaLoader has not loaded in yet */
this.pollQueriesOnce().catch((error) => {
log.error("Failed to poll queries", "remote");
console.error(error);
throw error;
}),
]);
Expand Down Expand Up @@ -350,15 +348,13 @@ export class Remote extends EventEmitter<RemoteEvents> {
this.schemaLoader = new SchemaLoader(this.sourceManager, source);
this.queryLoader.on("pollError", (error) => {
log.error("Failed to poll queries", "remote");
console.error(error);
});
this.queryLoader.on("poll", (queries) => {
this.optimizer.addQueries(queries).catch((error) => {
log.error(
`Failed to add ${queries.length} queries to optimizer`,
"remote",
);
console.error(error);
});
this.pgStatStatementsStatus = PgStatStatementsStatus.Installed;
}).on("pgStatStatementsNotInstalled", () => {
Expand Down
3 changes: 3 additions & 0 deletions src/sql/postgresjs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,9 @@ export function wrapPgPool(pool: Pool): Postgres {
// Handle idle client errors to prevent process crashes.
// Expected during DROP DATABASE ... WITH (FORCE) which terminates
// all connections to the target database.
pool.on("connect", (client) => {
client.on("notice", () => {});
});
pool.on("error", (err) => {
log.warn(`Pool idle client error: ${err.message}`, "postgres");
});
Expand Down
1 change: 0 additions & 1 deletion src/sync/pg-connector.ts
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,6 @@ ORDER BY
) {
throw new ExtensionNotInstalledError("pg_stat_statements");
}
console.error(err);
throw new PostgresError(err instanceof Error ? err.message : String(err));
}
}
Expand Down