ci: add subprocess/http/unix transport matrix to SQL E2E#1
Merged
Conversation
Exercise the full test/sql/* sqllogictest suite over all three VGI transports (subprocess/stdio, HTTP, AF_UNIX), not just subprocess. - ci/run-integration.sh: parameterize by $TRANSPORT. For http, boot the worker with `--http --port 0 --port-file <f>`, poll the port-file, set LOCATION=http://127.0.0.1:<port>, and inject `INSTALL httpfs FROM core; LOAD httpfs;` after each `LOAD vgi;` (the vgi HTTP transport rides on httpfs). For unix, boot with `--unix <sock>` and poll the socket. Trap-kill the out-of-band worker; cleanup preserves the real exit code. Add a silent-skip guard so a broken http leg cannot fake a pass (the sqllogictest runner auto-SKIPs errors containing "HTTP"). - pyproject.toml + nlp_worker.py PEP 723 header: add the `http` extra (vgi-python[http] -> waitress) so the worker can serve --http. Relock. - .github/workflows/ci.yml: integration job becomes an os x transport matrix; install the worker with `uv sync --frozen --extra http`. All three legs GREEN locally (haybarn-unittest): subprocess/unix 58 assertions, http 66 (httpfs inject). The table-in-out functions (entities/tokens/sentences/noun_chunks) carry no per-scan position state, so they need no cursor fix to survive HTTP continuations. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
rustyconover
force-pushed
the
ci-multi-transport
branch
from
3a2279d to
b0a9569
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exercise the full
test/sql/*sqllogictest suite over all three VGI transports (subprocess/stdio, HTTP, AF_UNIX), not just subprocess.ci/run-integration.sh: parameterized by$TRANSPORT. http boots--http --port 0 --port-file, polls the file, injectshttpfs; unix boots--unix <sock>. Silent-skip guard prevents a fake http pass.pyproject.toml+ PEP 723 header: add thehttpextra (vgi-python[http]-> waitress). Relocked.ci.yml: integration job is now an os x transport matrix;uv sync --frozen --extra http.All three legs GREEN locally: subprocess/unix 58 assertions, http 66 (httpfs inject). Table-in-out functions carry no per-scan position state, so no cursor fix needed.
🤖 Generated with Claude Code