-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix(qwik): guard null/undefined vNode in markVNodeDirty #8563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
juslintek
wants to merge
1
commit into
QwikDev:build/v2
Choose a base branch
from
juslintek:fix/guard-null-vnode-in-mark-dirty
base: build/v2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+37
−0
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@qwik.dev/core': patch | ||
| --- | ||
|
|
||
| fix: guard null/undefined vNode in markVNodeDirty | ||
|
|
||
| Prevent `TypeError: Cannot read properties of undefined (reading 'dirty')` crash in `markVNodeDirty` when callers pass an undefined vNode. This happens when `DomContainer.$destroy$()` is called during async qwikloader dispatch — `$getObjectById$` returns `undefined` for all pending deserialization, so `scheduleTask`, `scheduleEffects`, `_hmr`, `_val`, `_chk`, and `_res` all pass undefined vNodes to `markVNodeDirty`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import { describe, expect, it, vi } from 'vitest'; | ||
| import { markVNodeDirty } from './vnode-dirty'; | ||
| import { ChoreBits } from './enums/chore-bits.enum'; | ||
| import type { Container } from '../types'; | ||
|
|
||
| describe('markVNodeDirty', () => { | ||
| it('does not throw when vNode is undefined (destroyed container)', () => { | ||
| // After DomContainer.$destroy$(), $getObjectById$ returns undefined for all IDs. | ||
| // Callers like scheduleTask, _hmr, _val, _chk pass the deserialized result | ||
| // directly to markVNodeDirty — which would be undefined. | ||
| const container = {} as Container; | ||
| expect(() => { | ||
| markVNodeDirty(container, undefined as any, ChoreBits.TASKS); | ||
| }).not.toThrow(); | ||
| }); | ||
|
|
||
| it('does not throw when vNode is null', () => { | ||
| const container = {} as Container; | ||
| expect(() => { | ||
| markVNodeDirty(container, null as any, ChoreBits.TASKS); | ||
| }).not.toThrow(); | ||
| }); | ||
| }); | ||
|
Comment on lines
+6
to
+23
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you are testing a fix, not failing test case. If I understand it correctly, to test it correctly you need to test |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then its a bug that this funtion called on container destroyed, it is workaround not real fix