Conversation
Added an end date for the events Modified the month view to use fullcalendar (must upload fullcalendar by yourself, v4)
…the month view to use fullcalendar (must upload fullcalendar by yourself, v4)
|
|
||
| echo '<div class="', $cssClass, '">'; | ||
| echo $sender->Form->label('Event Date', 'EventCalendarDate'); | ||
| echo $sender->Form->label('Date de début', 'EventCalendarDate'); |
There was a problem hiding this comment.
Mixing languages inside of a plugin is a bad idea. People with an unsupported language would see that mixture. The Form->label() method is translating its text so if you translate "Event Date" in your language file, that translation will be used here
There was a problem hiding this comment.
I know, it's not clean, It was not my intention to publish this code.
| $year = date('Y'); | ||
| $yearRange = $year.'-'.($year + 1); | ||
| $fields = explode(',', t('EventCalendar.DateOrder', 'month,day,year')); | ||
| $fields = explode(',', t('EventCalendar.DateOrder', 'day,month,year')); |
There was a problem hiding this comment.
As a German I also prefer that format, but the other one is - as far as I know - more common in English language and just to be consistent, I have chosen it here and would like to stick with it. It's customizable by using the language file
There was a problem hiding this comment.
Yes, but i'm not used to develop using Vanilla features and as it was just for one site .. So i made it quick and dirty !
As the title says.. If it can help, it's cool, if not, sorry !
| $sender->addDefinition( | ||
| 'EventCalendarCategoryIDs', | ||
| json_encode(c('EventCalendar.CategoryIDs')) | ||
| json_encode(unserialize(c('EventCalendar.CategoryIDs'))) |
There was a problem hiding this comment.
Vanilla stopped the support for arrays in the config (somethig I still do not understand), but my prefered way now of dealing with such a simple list would be a comma separated list which gets exploded and imploded. Unserializing shouldn't be needed if serialization doesn't happen elsewhere. If it is done, that other place should be corrected
| $cssClass .= ' Hidden'; | ||
| if (!in_array($categoryID, unserialize(c('EventCalendar.CategoryIDs')))) { | ||
| $cssClass .= ' hidden'; | ||
| } |
There was a problem hiding this comment.
Vanilla uses upper case css class names. So "Hidden" is correct
| return sprintf( | ||
| t('EventCalendar.DateMarkup', '<div class="EventCalendarDate">%2$s On %1$s</div>'), | ||
| strftime(t('EventCalendar.DateFormat', '%A, %e. %B %Y'), strtotime($eventDate)), | ||
| strftime(t('EventCalendar.DateFormat', '%A, %e %B %Y'), strtotime($eventDate)), |
There was a problem hiding this comment.
The same as above: that is translatable so that source code doesn't need to be changed
|
|
||
| $sender->setData('Events', $eventCalendarModel->get("{$year}-{$month}-01", "{$year}-{$month}-{$daysInMonth}")); | ||
|
|
||
| $plusUn = $month+1; |
There was a problem hiding this comment.
Mixing language in source code is a bad idea. Furthermore there should be a blank before and after the plus sign. Vanilla normally uses speaking variables. Looking at a variable called "plus one" gives no hint about its meaning
There was a problem hiding this comment.
yeah i don't understand the syntax you're using just the line after
| $beginDate = date('Y-m-d', $beginDate); | ||
| } | ||
|
|
||
| var EventCalendarCategoryIDs = gdn.definition('EventCalendarCategoryIDs'); | ||
| if ( typeof EventCalendarCategoryIDs !== 'undefined' ) { | ||
| EventCalendarCategoryIDs = jQuery.parseJSON(EventCalendarCategoryIDs); | ||
| EventCalendarCategoryIDs = JSON.parse(EventCalendarCategoryIDs); |
There was a problem hiding this comment.
Yeah, kill jQuery references whereever it is possible!
|
Thanks for your support and welcome to GitHub! I've added several comments to your code. As it is by now, I will not merge it. I would ask you to split this: The first two things will be very easy for me to decide if I accept them or not. As I have noted, I would prefer explode/implode for the category IDs in the config. |
2 participants
So here a pull request for the compatibility with Vanilla 2.8. BUT, i've made other changes to your code, added an end date for the event (optional field). And i replaced the month view with FullCalendar.
But i didn't used the "Vanilla way" to insert Js / Css files.. It's directly called from the view, so not very clean ! I even have a little css block in the template, yes, i've done this "quickly" ! I'm not sure if it can help, but in any case, here you go !