Skip to content

fix(rh-developer): correct stale parameter names for prometheus_queryin incident-triage#100

Merged
dmartinol merged 1 commit into
mainfrom
fix/incident-triage-params
May 12, 2026
Merged

fix(rh-developer): correct stale parameter names for prometheus_queryin incident-triage#100
dmartinol merged 1 commit into
mainfrom
fix/incident-triage-params

Conversation

@ikrispin
Copy link
Copy Markdown
Contributor

@ikrispin ikrispin commented May 11, 2026

Summary

Fix according to readme: https://github.com/openshift/openshift-mcp-server

Pack(s) affected

  • rh-sre
  • rh-developer
  • ocp-admin
  • rh-virt
  • rh-ai-engineer
  • Other / repo-wide

Change type

  • New skill
  • New agent
  • New pack
  • Update existing skill / agent
  • MCP server config (mcps.json)
  • Docs / README
  • CI / tooling

CLAUDE.md compliance

  • Agents orchestrate skills; no direct MCP/tool calls in agents
  • Skills are single-purpose task executors
  • Skills encapsulate all tool access (MCP tools invoked only inside skills)
  • Document consultation: file is read with the Read tool, then declared to the user
  • No credentials hardcoded; env vars used via ${VAR} references
  • Human-in-the-loop confirmation added for any destructive or critical operations

Validation

  • make validate passes locally
  • New/changed skills have valid YAML frontmatter (name, description)
  • New/changed agents have valid YAML frontmatter (name, description)

@ikrispin ikrispin requested a review from dmartinol May 11, 2026 11:39
@dmartinol
Copy link
Copy Markdown
Collaborator

@jordigilh could you please tal?

@jordigilh
Copy link
Copy Markdown
Contributor

Hey @ikrispin, good catch on the stale parameter names — match and metric were leftovers from the old get_metric_names/get_metric_metadata tools that no longer exist.

While you're at it, there's one more artifact from the same rename in the Verification Steps section (lines 56-57). There are two nearly identical lines:

1. Check `openshift` server is configured in `mcps.json`
2. Check `openshift` server is configured in `mcps.json` with `observability` in its `--toolsets`

Line 1 is redundant — line 2 already covers it (and adds the observability toolset check). Could you remove line 1 and renumber the remaining steps? That way both leftovers are cleaned up in a single PR.

@r2dedios r2dedios added bug Something isn't working hold Hold, do not merge labels May 11, 2026
… verification step in incident-triage

Co-authored-by: Cursor <cursoragent@cursor.com>
@ikrispin ikrispin force-pushed the fix/incident-triage-params branch from 37b029e to e220107 Compare May 12, 2026 07:26
Copy link
Copy Markdown
Collaborator

@dmartinol dmartinol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! /lgtm

@dmartinol dmartinol merged commit 234553d into main May 12, 2026
2 checks passed
@ikrispin ikrispin deleted the fix/incident-triage-params branch May 12, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working hold Hold, do not merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants