Skip to content

MCPs server security review#94

Open
r2dedios wants to merge 4 commits into
RHEcosystemAppEng:mainfrom
r2dedios:hotfix/mcps-server-security-review
Open

MCPs server security review#94
r2dedios wants to merge 4 commits into
RHEcosystemAppEng:mainfrom
r2dedios:hotfix/mcps-server-security-review

Conversation

@r2dedios
Copy link
Copy Markdown
Contributor

@r2dedios r2dedios commented May 8, 2026

Summary

Resolved security issues with MCP servers versioning and removed "latest" tags

Pack(s) affected

  • rh-sre
  • rh-developer
  • ocp-admin
  • rh-virt
  • rh-ai-engineer
  • Other / repo-wide

Change type

  • New skill
  • New agent
  • New pack
  • Update existing skill / agent
  • MCP server config (mcps.json)
  • Docs / README
  • CI / tooling

CLAUDE.md compliance

  • Agents orchestrate skills; no direct MCP/tool calls in agents
  • Skills are single-purpose task executors
  • Skills encapsulate all tool access (MCP tools invoked only inside skills)
  • Document consultation: file is read with the Read tool, then declared to the user
  • No credentials hardcoded; env vars used via ${VAR} references
  • Human-in-the-loop confirmation added for any destructive or critical operations

Validation

  • make validate passes locally
  • New/changed skills have valid YAML frontmatter (name, description)
  • New/changed agents have valid YAML frontmatter (name, description)

@r2dedios r2dedios changed the title Hotfix/mcps server security review MCPs server security review May 8, 2026
@r2dedios
Copy link
Copy Markdown
Contributor Author

r2dedios commented May 8, 2026

NOT READY for review yet. Performing last test round to ensure every skill can use the MCP and tools properly

Comment thread rh-ai-engineer/README.md Outdated
@r2dedios
Copy link
Copy Markdown
Contributor Author

I tested both packages installation and deployment (MCPs included) and now it is working correctly. PR ready for review @dmartinol

@r2dedios r2dedios requested a review from dmartinol May 11, 2026 10:40
@r2dedios r2dedios self-assigned this May 11, 2026
@r2dedios r2dedios added enhancement New feature or request hold Hold, do not merge labels May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request hold Hold, do not merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants