[WIP] feat: implement OAuth client secret rotation#166
Closed
IlonaShishov wants to merge 2 commits into
Closed
Conversation
…ub notifications Introduce a Cloud Run rotation setup script that configures Secret Manager rotation schedules and Pub/Sub SECRET_ROTATE notifications for redhat-sso-client-secret and gma-client-secret, and document/cleanup the new rotation resources in deployment scripts. Made-with: Cursor
- Add POST /rotation endpoint with Pub/Sub OIDC verification - Implement provider registry with ABC template method pattern - Add RedHatSSOSecretProvider and GMASecretProvider placeholders - Add comprehensive error handling and structured logging - Tests: 27 passing (~1700 lines new code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
12fe38e to
518058f
Compare
Collaborator
Author
|
Credential providers do not support automated secret rotation, closing for now, implementing manual policy instead #181 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements automatic OAuth client secret rotation for
redhat-sso-client-secretandgma-client-secretusing Google SecretManager's native rotation features.
What's Included
Infrastructure:
Rotation Endpoint:
/rotationendpoint integrated with marketplace handlerArchitecture:
SecretValueProviderABC with template method patternRedHatSSOSecretProviderfor Red Hat Identity API integrationGMASecretProviderfor Google Marketplace Admin API integrationSecretProviderRegistryroutes secrets to providersHow It Works
next_rotation_timeis reached/rotationendpoint with OIDC JWTTesting
All rotation tests passing (27 tests):
Deployment
See
deploy/cloudrun/README.mdfor:setup-secret-rotation.sh