[SAR] APPENG-5142: MCP HTTPS enforcement for non-localhost#193
Open
yuvalk wants to merge 1 commit into
Open
Conversation
…st targets Add a model validator that logs a warning when MCP_SERVER_URL uses unencrypted HTTP for non-localhost hosts. Bearer tokens forwarded to the MCP server would be transmitted in cleartext, risking credential exposure. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
|
some fixes at: yuvalk#9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses APPENG-5142.
Adds a startup-time warning when
MCP_SERVER_URLuses unencrypted HTTP for non-localhost hosts. The agent forwards Bearer tokens to the MCP server, which would be transmitted in cleartext over insecure connections.Changes
_warn_mcp_insecure_urlmodel validator insrc/lightspeed_agent/config/settings.pythat logs a warning for non-localhost HTTP MCP URLsSAR Reference
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com