APPENG-4146: Fix checklist parsing issue caused by unescaped quotes#232
Open
gnetanel wants to merge 3 commits into
Conversation
Checklist generation was failing during parsing due to unescaped quote characters. This change updates the regex used to find unescaped quote characters in the LLM checklist response.
zvigrinberg
requested changes
May 7, 2026
Collaborator
zvigrinberg
left a comment
zvigrinberg
left a comment
There was a problem hiding this comment.
Hi @gnetanel,
Please add few relevant tests ( Unit-test ones).
Thank you.
Add unit tests for checklist_prompt_generator._parse_list
gnetanel
force-pushed
the
APPENG-4146_bugfix_generating_checklist_parsing_issue_change_regex_approach
branch
from
e437bc4 to
886abea
Compare
Add additional unit tests to verify additional escape sequences
gnetanel
force-pushed
the
APPENG-4146_bugfix_generating_checklist_parsing_issue_change_regex_approach
branch
from
23994a7 to
1ee5e05
Compare
Collaborator
|
/test-heavy |
1 similar comment
Collaborator
Author
|
/test-heavy |
Collaborator
Author
|
/test-heavy |
1 similar comment
Collaborator
Author
|
/test-heavy |
Collaborator
|
/test vulnerability-analysis-on-pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist generation was failing during parsing due to unescaped quote characters. This change updates the regex used to find unescaped quote characters in the LLM checklist response.