update triton version for sglang-atom docker#698
Open
zhuyuhua-v wants to merge 4 commits intomainfrom
Open
Conversation
Signed-off-by: zhuyuhua-v <yuhzhu@amd.com>
Signed-off-by: zhuyuhua-v <yuhzhu@amd.com>
zhuyuhua-v
force-pushed
the
yuhua/sgl-docker-triton
branch
from
14c6754 to
b523016
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modifies the atom_sglang Docker image build to avoid SGLang dependency installation perturbing the Triton installation in the ATOM base image, by backing up the base Triton and restoring it after installs.
Changes:
- Removed the explicit
triton==3.6.0install override for the SGLang image. - Added a “backup base Triton” step before SGLang dependency installation.
- Added a “restore base Triton” step after SGLang dependency installation (with import-version verification).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+179
to
+181
| # Preserve the exact Triton that comes with the ATOM base image. SGLang installs | ||
| # can perturb Triton metadata, so restore this copy after dependency installs. | ||
| RUN echo "========== [SGLANG-ATOM 0/6] Back up base image triton ==========" && \ |
Comment on lines
+197
to
+202
| echo "ERROR: Expected at least one Triton dist-info directory in the ATOM base image." && \ | ||
| ls -d /opt/venv/lib/python3.12/site-packages/*triton*.dist-info || true && \ | ||
| exit 1; \ | ||
| fi && \ | ||
| echo "Base image triton backed up: import_version=${BASE_TRITON_VERSION}, metadata_count=${METADATA_COUNT}" && \ | ||
| ls -d /tmp/sglang-triton-base-backup/*.dist-info |
| ENV PYTHONPATH="/app/sglang/python:/app/ATOM:${PYTHONPATH}" | ||
|
|
||
| RUN echo "========== [SGLANG-ATOM 0/6] Check Aiter/FlyDSL versions before SGLang build ==========" && \ | ||
| RUN echo "========== [SGLANG-ATOM] Check Aiter/FlyDSL versions before SGLang build ==========" && \ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
update triton version for sglang-atom docker
Technical Details
Test Plan
Test Result
Submission Checklist