Open
Conversation
Contributor
Author
|
updates: fuse the upcast of |
Contributor
Author
|
updates: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes:
ATOM_V4_USE_TRITON_FUSION)ATOM_V4_USE_TRITON_FUSION)ATOM_ENABLE_DS_QKNORM_QUANT_FUSIONin DSV4 (the API is imported fromdeepseek_v2.py)combined = self.wkv_gate(x, otype=torch.bfloat16)into_fused_compress_attn_kernelneg1 = positions.new_full((), -1)atatom/model_ops/attentions/deepseek_v4_attn.pythat prevent host-side sync, 5% improvement end-to-endThis PR requires ROCm/aiter#3057
baseline lm_eval
fused lm_eval
so far I am seeing ~10% runtime reduction in the trace in decode and not runtime difference in prefill
baseline decode

fused decode

in end-to-end performance, I saw 8% performance uplift, but ~5% comes from item 5), all other optimization, 1) ~ 4), should be around ~10% of improvement yet we only saw 3%, there may be other things other than 5) that is blocking the performance.
Baseline
With all the optimization in this PR