docs: deploy compressor page with docs workflow#715
Open
gyohuangxin wants to merge 2 commits intomainfrom
Open
docs: deploy compressor page with docs workflow#715gyohuangxin wants to merge 2 commits intomainfrom
gyohuangxin wants to merge 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR moves the “Dissecting DeepSeek V4 Compressor” interactive animation into the documentation tree and publishes it via the existing Sphinx docs GitHub Pages deployment, removing the now-redundant standalone Pages workflow.
Changes:
- Add the compressor animation page under
docs/dissecting_dsv4_compressor/. - Extend the docs workflow to copy the page into the built HTML output before deploying to GitHub Pages.
- Update the README link to point at the docs-hosted URL and remove the standalone Pages deployment workflow.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Updates the News link to the docs-hosted compressor page URL. |
| docs/dissecting_dsv4_compressor/index.html | Adds the standalone interactive animation page into the docs tree. |
| .github/workflows/docs.yml | Copies the animation directory into the Sphinx build output before publishing under docs/ on gh-pages. |
| .github/workflows/deploy-pages.yml | Removes the standalone static Pages deploy workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| run: | | ||
| cd docs | ||
| make html | ||
| cp -r dissecting_dsv4_compressor _build/html/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/so it is owned by the documentation tree.Test plan
docs/_build/html/dissecting_dsv4_compressor/index.htmlis produced after the docs workflow copy step.