Skip to content

Optimize func_solve_init#25

Open
EricKing626 wants to merge 3 commits intoamd-integrationfrom
eric_dev_0424
Open

Optimize func_solve_init#25
EricKing626 wants to merge 3 commits intoamd-integrationfrom
eric_dev_0424

Conversation

@EricKing626
Copy link
Copy Markdown

@EricKing626 EricKing626 commented Apr 24, 2026

  1. Speedup tiled Hessian kernel

Use direct lower-triangle indexing for Hessian computation
Eliminates redundant upper-triangle calculations in diagonal tiles
Reduces computation overhead in func_hessian_direct_tiled

  1. Speed up rigid constraint solver init ([MISC] Speed up rigid constraint solver init. Genesis-Embodied-AI/genesis-world#2521)

Add parallel initialization strategy for constraint Jacobian
Parallelize over (constraints × envs) when GPU is under-saturated (n_envs < GPU cores)
Auto-detects AMD/NVIDIA hardware and adjusts parallelization accordingly
Implements _initialize_Jaref_parallel() for better GPU utilization

@EricKing626
Copy link
Copy Markdown
Author

/run-ci

1 similar comment
@yaoliu13
Copy link
Copy Markdown
Collaborator

/run-ci

Copy link
Copy Markdown
Collaborator

@yaoliu13 yaoliu13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-submit is 752k

@EricKing626 EricKing626 force-pushed the eric_dev_0424 branch 2 times, most recently from f9988a6 to a4aeea3 Compare April 30, 2026 00:41
Copy link
Copy Markdown
Collaborator

@yaoliu13 yaoliu13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has conflicts if we want to merge it to amd-integration. Please read Confluence page "Genesis PR Review Process".

@yaoliu13
Copy link
Copy Markdown
Collaborator

yaoliu13 commented May 4, 2026

/run-ci

@yaoliu13
Copy link
Copy Markdown
Collaborator

yaoliu13 commented May 5, 2026

/run-ci

@yaoliu13
Copy link
Copy Markdown
Collaborator

yaoliu13 commented May 6, 2026

/run-ci

@yaoliu13
Copy link
Copy Markdown
Collaborator

yaoliu13 commented May 6, 2026

/run-ci

1 similar comment
@yaoliu13
Copy link
Copy Markdown
Collaborator

yaoliu13 commented May 6, 2026

/run-ci

@nilapate nilapate self-requested a review May 7, 2026 05:10
Copy link
Copy Markdown

@vrachuma vrachuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown

@amd-anchaudh amd-anchaudh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yaoliu13
Copy link
Copy Markdown
Collaborator

yaoliu13 commented May 7, 2026

/run-ci

1 similar comment
@yaoliu13
Copy link
Copy Markdown
Collaborator

yaoliu13 commented May 7, 2026

/run-ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants