Add support for enabling/querying local memory exceptions. by oogunbow-amd · Pull Request #105 · ROCm/ROCgdb

oogunbow-amd · 2026-04-29T13:12:29Z

This feature allows users to detect out‑of‑address-range accesses to local memory (LDS) during debugging sessions using new set/show lds-out-of-addr-range-exceptions commands.

Updated target data structures, attach/detach logic, and clone/fork handling to propagate the new setting. Adjusted build configuration to require amd‑dbgapi ≥ 0.81.0.

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

This feature allows users to detect out‑of‑address-range accesses to local memory (LDS) during debugging sessions using new set/show lds-out-of-addr-range-exceptions commands. Updated target data structures, attach/detach logic, and clone/fork handling to propagate the new setting. Adjusted build configuration to require amd‑dbgapi ≥ 0.81.0.

simark

The commit message says set/show lds-out-of-addr-range-exceptions, so I was going to say this setting should probably be under set/show amdgpu, but that's what the code actually does. So I think the commit message should be updated to reflect that.

amd-shahab · 2026-05-01T20:44:09Z

+  - set amdgpu lds-out-of-addr-exception
+  - show amdgpu lds-out-of-addr-exception
+
+## ROCgdb-X for ROCm-next


these new added lines are duplicate and should be removed.

## ROCgdb-X for ROCm-next ### Added

The new entries should also go at the end of the "Added" list.

amd-shahab · 2026-05-01T20:46:25Z

+  cmds = add_setshow_boolean_cmd ("lds-out-of-address-range-exception", no_class,
+                                 _("Set lds-out-of-address-range-exception mode."),
+                                 _("Show lds-out-of-address-range-exception mode."), _("\
+If on, local memory out-of-address-range exception reporting is enabled if/when\n\


looks like you copy/pasted this from the code block above, nonetheless I think "if/when" is not adding any value. a mere "when" would suffice.

amd-shahab · 2026-05-01T20:51:34Z

+/* Callback for "show amdgpu lds-out-of-address-range-exception".  */
+
+static void
+show_local_memory_out_of_addr_range_exception_mode (struct ui_file *file, int from_tty,


right now, this line is above 80 column limit (87 chars to be exact).

the function name is 50 characters long. show_lds_addr_range_excp_mode() maybe? the same holds true for other functions.

amd-shahab · 2026-05-01T20:58:15Z

+
+static void
+show_local_memory_out_of_addr_range_exception_mode (struct ui_file *file, int from_tty,
+				  struct cmd_list_element *c, const char *value)


The alignment of the text is off.

I'm going to suppress other GNU coding standard violations at this point. Please find and fix them.

amd-shahab · 2026-05-01T21:00:27Z

  return info.precise_alu_exceptions.enabled;
 }

+/* Callback for "show amdgpu lds-out-of-address-range-exception".  */


lds-addr-range-exception ?

amd-shahab · 2026-05-01T21:12:53Z

@@ -0,0 +1,57 @@
+# Copyright (C) 2022-2025 Advanced Micro Devices, Inc. All rights reserved.


amd-shahab · 2026-05-01T21:13:51Z

@@ -0,0 +1,48 @@
+/* Copyright (C) 2022-2025 Advanced Micro Devices, Inc. All rights reserved.


amd-shahab · 2026-05-01T21:15:13Z

+#include <stdio.h>
+#include <stdlib.h>
+
+#define CHECK(cmd)                                                           \


#include "rocm-test-utils.h" and drop the definition of CHECK().

amd-shahab · 2026-05-01T21:16:12Z

+      }                                                                      \
+  }
+
+typedef void (*func_ptr) ();


why this typedef? I don't see func_ptr used anywhere.

amd-shahab · 2026-05-01T21:18:16Z

+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+# Test debugging a program that branches to a bad address.  Check that


I don't think this description is up-to-date. moreover, maybe shared-exceptions is not the best name for this test.

palves · 2026-05-04T10:14:36Z

 		 "Warning: precise memory violation signal reporting is not enabled, reported" \
 		 "location may not be accurate.  See \"show amdgpu precise-memory\"\\." \
+		 "Warning: local memory out-of-address-range exception reporting is not enabled\\." \
+		 "See \"show amdgpu lds-out-of-addr-exception\"\\." \


So what happens if you turn this on? Please explain it in the commit log, ideally with a short/concise example.

palves · 2026-05-04T10:17:24Z

-     copy the precise memory request, it will be applied when the process
-     starts.  */
+     copy the precise memory and local memory request, it will be applied when
+     the process starts.  */


We now have two things, so some words must be adjusted for plural:

request => requests
it will be => they will be

palves · 2026-05-04T10:18:50Z

+                                 set_local_memory_out_of_addr_range_exception_mode,
+                                 get_local_memory_out_of_addr_range_exception_mode,
+                                 show_local_memory_out_of_addr_range_exception_mode,
+                                 &set_amdgpu_list, &show_amdgpu_list);


This setting / feature must be documented in the GDB manual.

palves · 2026-05-04T10:20:41Z

Please drop period from commit log.

oogunbow-amd requested a review from a team as a code owner April 29, 2026 13:12

oogunbow-amd self-assigned this Apr 29, 2026

oogunbow-amd requested review from amd-shahab, lancesix and lumachad April 29, 2026 13:13

simark reviewed Apr 29, 2026

View reviewed changes

amd-shahab reviewed May 1, 2026

View reviewed changes

palves reviewed May 4, 2026

View reviewed changes

		@@ -0,0 +1,57 @@
		# Copyright (C) 2022-2025 Advanced Micro Devices, Inc. All rights reserved.

		@@ -0,0 +1,48 @@
		/* Copyright (C) 2022-2025 Advanced Micro Devices, Inc. All rights reserved.

Conversation

oogunbow-amd commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

Uh oh!

simark left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

palves commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

oogunbow-amd commented Apr 29, 2026 •

edited

Loading