gdb/testsuite/gdb.rocm/finish: Test small mixed struct#108
Open
lancesix wants to merge 2 commits intoamd-stagingfrom
Open
gdb/testsuite/gdb.rocm/finish: Test small mixed struct#108lancesix wants to merge 2 commits intoamd-stagingfrom
lancesix wants to merge 2 commits intoamd-stagingfrom
Conversation
amd-shahab
reviewed
May 1, 2026
lancesix
force-pushed
the
users/lancesix/add-finish-mixed-small-struct
branch
2 times, most recently
from
936869e to
781fef9
Compare
Collaborator
Author
|
I have added another patch tightening the escaping of {} in TCL. |
Collaborator
|
If possible, we should make sure this doesn't introduce additional optimized testsuite run failures. See https://github.com/ROCm/ROCgdb/pull/103/changes#diff-e3a7e92eaec07842270f3368e58638fc70df14eaa828b7e2fcf00a4f2dab72ca for example on how this test was adjusted to not cause FAIL's when compiled with O1~O3. |
This patch extends the gdb.rocm/finish.exp testcase to cover small (up to 64 bytes) struct containing some sub 32 bits elements (short in this case) and a float element. This test is here extend our coverage of ABI stability. Suggested-by: Qadeer, Hafiz Abid <HafizAbid.Qadeer@amd.com> Change-Id: I2a56ddd7712e58d2f4fa5da21182bd4e76b1873e
The gdb.rocm/finish.exp seem to have somewhat invalid (but still
accepted) escaping of the { and } characters in the gdb_test argument.
In all cases, the argument is quoted with "", so the {} character have
no special meaning in TCL, but have in the regexpr that comes.
Therefore, the { and } char shouldb e escaped in the produced regex
(i.e. "\{"), so this should look like "\\{" in TCL. This way TCL first
processes the backslash escpape to turn "\\" into "\", and "{" remains
unchanged.
Change-Id: Iacd5ad7eee925b0479f7090f60286c97c48f55a8
lancesix
force-pushed
the
users/lancesix/add-finish-mixed-small-struct
branch
from
781fef9 to
9b4e731
Compare
Collaborator
Author
I have added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch extends the gdb.rocm/finish.exp testcase to cover small (up to 64 bytes) struct containing some sub 32 bits elements (short in this case) and a float element. This test is here extend our coverage of ABI stability.
Suggested-by: Qadeer, Hafiz Abid HafizAbid.Qadeer@amd.com
Change-Id: I2a56ddd7712e58d2f4fa5da21182bd4e76b1873e