Skip to content

[amd-staging-rocgdb-16] ROCgdb cherry picks from origin/amd-staging (2026-05-07)#113

Open
lumachad wants to merge 2 commits intoamd-staging-rocgdb-16from
users/lumachad/amd-staging-rocgdb-16/cherry-picks-07052026
Open

[amd-staging-rocgdb-16] ROCgdb cherry picks from origin/amd-staging (2026-05-07)#113
lumachad wants to merge 2 commits intoamd-staging-rocgdb-16from
users/lumachad/amd-staging-rocgdb-16/cherry-picks-07052026

Conversation

@lumachad
Copy link
Copy Markdown
Collaborator

@lumachad lumachad commented May 7, 2026

Commits:

e514371 Update In Memoriam section
2c625f8 Update TheRock dependencies and container images

@lumachad lumachad self-assigned this May 7, 2026
@lumachad lumachad requested a review from a team as a code owner May 7, 2026 08:14
@lumachad lumachad requested a review from lancesix May 7, 2026 08:14
@github-actions github-actions Bot changed the title ROCgdb cherry picks from origin/amd-staging (2026-05-07) [amd-staging-rocgdb-16] ROCgdb cherry picks from origin/amd-staging (2026-05-07) May 7, 2026
@lumachad
Copy link
Copy Markdown
Collaborator Author

lumachad commented May 7, 2026

@lancesix I skipped the merge adjustments, which I think are only a concern for amd-staging.

@lancesix
Copy link
Copy Markdown
Collaborator

lancesix commented May 7, 2026

@lancesix I skipped the merge adjustments, which I think are only a concern for amd-staging.

Sure.

In the last merge from upstream, didn't we have commit 8e77de4 which we would probably want here as well?

@lumachad
Copy link
Copy Markdown
Collaborator Author

lumachad commented May 7, 2026

@lancesix I skipped the merge adjustments, which I think are only a concern for amd-staging.

Sure.

In the last merge from upstream, didn't we have commit 8e77de4 which we would probably want here as well?

True. Let me check why that didn't show up.

@lumachad lumachad marked this pull request as draft May 7, 2026 09:54
@lumachad
Copy link
Copy Markdown
Collaborator Author

lumachad commented May 7, 2026

Back to draft while I check this.

@lumachad lumachad force-pushed the users/lumachad/amd-staging-rocgdb-16/cherry-picks-07052026 branch from 9108fd9 to 9fb10d0 Compare May 7, 2026 10:24
@lumachad lumachad marked this pull request as ready for review May 7, 2026 10:24
@lumachad
Copy link
Copy Markdown
Collaborator Author

lumachad commented May 7, 2026

I think this is correct now. Could you please double check @lancesix?

@lancesix
Copy link
Copy Markdown
Collaborator

lancesix commented May 7, 2026

Building this, I get:

  CXX    dwarf2/read.o
../../gdb/bt-utils.c: In function ‘void gdb_internal_backtrace()’:
../../gdb/bt-utils.c:182:16: error: ‘str_backtrace_unavailable’ was not declared in this scope
  182 |     sig_write (str_backtrace_unavailable);
      |                ^~~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [Makefile:1963: bt-utils.o] Error 1
make[2]: *** Waiting for unfinished jobs....
../../gdb/dwarf2/read.c: In function ‘symbol* new_symbol(die_info*, type*, dwarf2_cu*, symbol*)’:
../../gdb/dwarf2/read.c:19315:49: error: expression cannot be used as a function
19315 |             && !file_cu->per_cu->is_debug_types ())
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
../../gdb/dwarf2/read.c:19325:15: error: return-statement with no value, in function returning ‘symbol*’ [-fpermissive]
19325 |               return;
      |               ^~~~~~
make[2]: *** [Makefile:1963: dwarf2/read.o] Error 1

So it turns out that 8e77de4 is not needed on this branch, and e7dc0a8 seems to have issues.

@lumachad
Copy link
Copy Markdown
Collaborator Author

lumachad commented May 7, 2026

Building this, I get:

  CXX    dwarf2/read.o
../../gdb/bt-utils.c: In function ‘void gdb_internal_backtrace()’:
../../gdb/bt-utils.c:182:16: error: ‘str_backtrace_unavailable’ was not declared in this scope
  182 |     sig_write (str_backtrace_unavailable);
      |                ^~~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [Makefile:1963: bt-utils.o] Error 1
make[2]: *** Waiting for unfinished jobs....
../../gdb/dwarf2/read.c: In function ‘symbol* new_symbol(die_info*, type*, dwarf2_cu*, symbol*)’:
../../gdb/dwarf2/read.c:19315:49: error: expression cannot be used as a function
19315 |             && !file_cu->per_cu->is_debug_types ())
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
../../gdb/dwarf2/read.c:19325:15: error: return-statement with no value, in function returning ‘symbol*’ [-fpermissive]
19325 |               return;
      |               ^~~~~~
make[2]: *** [Makefile:1963: dwarf2/read.o] Error 1

So it turns out that 8e77de4 is not needed on this branch, and e7dc0a8 seems to have issues.

Indeed. Let me drop those.

neon60 and others added 2 commits May 7, 2026 05:50
Replace ROCgdb with GDB

(cherry picked from commit e514371)
TheRock commit:
  8df747734dda -> 54acd32c58aa

(cherry picked from commit 2c625f8)
@lumachad lumachad force-pushed the users/lumachad/amd-staging-rocgdb-16/cherry-picks-07052026 branch from 9fb10d0 to f8a6e52 Compare May 7, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants