[amd-staging-rocgdb-16] gdb: Skip rocm watchpoint tests in case not all GPUs are supported#115
Open
motokultivator wants to merge 1 commit intoamd-staging-rocgdb-16from
Open
Conversation
In the case where there are multiple GPUs on the system, and some of them are not supported, rocgdb issues a warning about this during the "run" command. This change introduces recognition of this warning and skips tests that would fail in such cases. A new procedure has been introduced, in rocm.exp, for this purpose, which can be extended to recognize other specific warnings. The tests affected by this are: gdb.rocm/aspace-watchpoint.exp gdb.rocm/watchpoint-at-end-of-shader.exp gdb.rocm/precise-memory-warning-watchpoint.exp
github-actions
Bot
changed the title
Collaborator
|
Please target amd-staging. amd-staging-rocgdb-16 is only supposed to get cherry-picks. |
Contributor
|
Also, if there are changes that would apply to upstream, would you like to send them upstream? I don't mind doing it but if you want to do it by yourself it's fine to, just let me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case where there are multiple GPUs on the system, and some of them are not supported, rocgdb issues a warning about this during the "run" command. This change introduces recognition of this warning and skips tests that would fail in such cases.
A new procedure has been introduced, in rocm.exp, for this purpose, which can be extended to recognize other specific warnings.
The tests affected by this are:
gdb.rocm/aspace-watchpoint.exp
gdb.rocm/watchpoint-at-end-of-shader.exp
gdb.rocm/precise-memory-warning-watchpoint.exp