Support channel first layout in fused_conv_bias_relu extension #315
Open
amd-sriram wants to merge 1 commit into
Open
Support channel first layout in fused_conv_bias_relu extension #315amd-sriram wants to merge 1 commit into
amd-sriram wants to merge 1 commit into
Conversation
…format, destroy variables if fusion fails, if fusion fails then fallback to non-fusion approach
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The current implementation of fused_conv_bias_relu doesn't support channel first inputs currently for fused_conv_bias.
rocm7.1 error
rocm 7.2 error
Fixes: #309
Technical Details
CK backend for conv_bias module expects the workspace to be allocated.
So, the solution is to
In addition, fixed the code so that it handles case when fusion fails:
Test Plan
Run the test code and the example code provided in the issue in 7.1 and 7.2 dockers.
Test Result
Submission Checklist