Skip to content

CI: Implement automatic pre-commit checks with a GHA workflow#320

Merged
jithunnair-amd merged 3 commits into
masterfrom
leo/implement-precommit-checks
Apr 20, 2026
Merged

CI: Implement automatic pre-commit checks with a GHA workflow#320
jithunnair-amd merged 3 commits into
masterfrom
leo/implement-precommit-checks

Conversation

@leo-automation
Copy link
Copy Markdown
Collaborator

@leo-automation leo-automation commented Mar 18, 2026

hooks:
-   id: trailing-whitespace
-   id: check-ast
-   id: check-json
-   id: check-merge-conflict
-   id: check-toml
-   id: check-yaml

@jithunnair-amd
Copy link
Copy Markdown
Collaborator

Thanks @leo-amd for the PR. Let's merge this PR only after all the pre-commit checks are clean.

@amd-sriram It seems the extra spaces check caught some legit instances: https://github.com/ROCm/apex/actions/runs/23252552729/job/67598289100?pr=320
Can you please fix them in a different PR, so we can rebase this PR and rerun the checks to go to the next set of errors? If you run these pre-commit checks locally, that'd be best.

@jithunnair-amd jithunnair-amd mentioned this pull request Mar 23, 2026
1 task
@amd-sriram amd-sriram mentioned this pull request Mar 27, 2026
1 task
@jithunnair-amd
Copy link
Copy Markdown
Collaborator

Thanks @leo-amd for the PR. Let's merge this PR only after all the pre-commit checks are clean.

@amd-sriram It seems the extra spaces check caught some legit instances: https://github.com/ROCm/apex/actions/runs/23252552729/job/67598289100?pr=320 Can you please fix them in a different PR, so we can rebase this PR and rerun the checks to go to the next set of errors? If you run these pre-commit checks locally, that'd be best.

#324 filed to address lint errors

@jithunnair-amd jithunnair-amd force-pushed the leo/implement-precommit-checks branch from 9e591d7 to e44d530 Compare April 20, 2026 15:27
@jithunnair-amd jithunnair-amd merged commit 3cff712 into master Apr 20, 2026
2 checks passed
@jithunnair-amd jithunnair-amd deleted the leo/implement-precommit-checks branch April 20, 2026 15:34
@jithunnair-amd
Copy link
Copy Markdown
Collaborator

! cherry-pick --onto release/1.9.0 release/1.10.0 release/1.11.0 release/1.12.0

@rocm-repo-management-api-6
Copy link
Copy Markdown

Can't perform the cherry-pick keyword: unexpected error

Comment processed by Build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants