Fixed 'Memory access fault' error for fused dense on MI350#325
Merged
jithunnair-amd merged 1 commit intoApr 20, 2026
Merged
Conversation
|
LGTM |
|
maybe in another PR, need to use hipblaslt api and pointers. |
Author
|
The CI doesn't check MI350 so as a confirmation I attach the screenshot of local execution:
Also, the original L0 CI didn't get broken: https://github.com/ROCm/apex/actions/runs/24464892682/job/71499106039?pr=325#logs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
The error reported by QA: Memory access fault when running fused dense cuda on MI350.
Technical Details
In gemm_lt (ROCm / USE_ROCM path in csrc/fused_dense_cuda.cu), replace
at::cuda::getCurrentCUDABlasHandle()withat::cuda::getCurrentCUDABlasLtHandle()for the handle used with hipblasGetStream and hipblasLtMatmul (and the rest of the Lt setup in that function).Test Plan
Build the fused_dense_cuda extension on ROCm (e.g. JIT or full Apex build targeting your arch, e.g. gfx950).
Run the ROCm Apex test driver, e.g.
APEX_TEST_WITH_ROCM=1 APEX_SKIP_FLAKY_TEST=1 python run_test.py(or your repo’s run_rocm.sh wrapper).Test Result