Add USE_ROCM to op_builder/builder.py#326
Open
jithunnair-amd wants to merge 1 commit into
Open
Conversation
1 task
Collaborator
Author
|
@albmalamd Please assess whether we need to remove or keep env vars and why. CUDAExtension should take care of specifying some of these env vars already |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Changes brought over from #324, as these were the only non-whitespace changes in that PR.
Technical Details
Adding USE_ROCM compile flag
Test Plan
Test Apex extension build
Test Result
Build and tests should succeed
Submission Checklist