Skip to content

Propagate EP session option modifications during provider creation #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
KenLagos wants to merge 1 commit into
base: rel-1.24.4-wml
Choose a base branch
from
Draft

Propagate EP session option modifications during provider creation #238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion onnxruntime/core/session/utils.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,11 +423,24 @@ OrtStatus* InitializeSession(_In_ const OrtSessionOptions* options,

if (has_provider_factories) {
std::vector<std::unique_ptr<IExecutionProvider>> provider_list;

// Create OrtSessionOptions wrapper for the CreateProvider call.
// Once the InferenceSession is created, its SessionOptions is the source of truth
// and contains all the values from the user provided OrtSessionOptions.
// We wrap the session's copy so any modifications made by the EP (e.g., DisableMemPattern)
// will affect the actual session options that will be used.
auto& session_options = sess.GetMutableSessionOptions();
OrtSessionOptions ort_so;
ort_so.value = session_options;

for (auto& factory : options->provider_factories) {
auto provider = factory->CreateProvider(*options, *session_logger->ToExternal());
auto provider = factory->CreateProvider(ort_so, *session_logger->ToExternal());
provider_list.push_back(std::move(provider));
}

// Copy any modifications made by the EP back to the session's options
session_options = ort_so.value;

// register the providers
for (auto& provider : provider_list) {
if (provider) {
Expand Down
Loading